r3672 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r3671‎ | r3672 | r3673 >
Date:16:54, 23 May 2004
Author:gabrielwicke
Status:old
Tags:
Comment:
keep image stuff on one line to help parser in cases where a thumb is embedded in a list ( :[[image:something\|thumb]])
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -1833,9 +1833,9 @@
18341834 "<img src=\"{$url}\" alt=\"{$alt}\" /></a>";
18351835 }
18361836 if ( "" != $align ) {
1837 - $s = "<div class=\"float{$align}\"><span>{$s}</span>\n</div>";
 1837+ $s = "<div class=\"float{$align}\"><span>{$s}</span></div>";
18381838 }
1839 - return $prefix.$s.$postfix;
 1839+ return str_replace("\n", ' ',$prefix.$s.$postfix);
18401840 }
18411841
18421842
——@@ -1897,8 +1897,8 @@
18981898 'width="15" height="11" alt="'.$more.'" /></a></div>';
18991899 }
19001900 }
1901 - $s .= ' <div class="thumbcaption" '.$textalign.'>'.$zoomicon.$label."</div></div>\n</div>";
1902 - return $s;
 1901+ $s .= ' <div class="thumbcaption" '.$textalign.'>'.$zoomicon.$label."</div></div></div>";
 1902+ return str_replace("\n", ' ', $s);
19031903 }
19041904
19051905 function makeMediaLink( $name, $url, $alt = "" ) {

Status & tagging log