r36673 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36672‎ | r36673 | r36674 >
Date:14:00, 26 June 2008
Author:ialex
Status:old
Tags:
Comment:
Using WikiError seems to be useless here
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -315,8 +315,7 @@
316316
317317 case self::OVERWRITE_EXISTING_FILE:
318318 $errorText = $details['overwrite'];
319 - $overwrite = new WikiError( $wgOut->parse( $errorText ) );
320 - $this->uploadError( $overwrite->toString() );
 319+ $this->uploadError( $wgOut->parse( $errorText ) );
321320 break;
322321
323322 case self::FILETYPE_MISSING:

Follow-up revisions

RevisionCommit summaryAuthorDate
r36676Revert my revert. It wasn't me for a change....siebrand15:40, 26 June 2008

Status & tagging log