r36662 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36661‎ | r36662 | r36663 >
Date:00:26, 26 June 2008
Author:demon
Status:old
Tags:
Comment:
(bug 14647) Remove unused 'townBox' class from global CSS.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)
  • /trunk/phase3/skins/simple/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/simple/rtl.css
@@ -66,7 +66,6 @@
6767 }
6868
6969 div.magnify,
70 -#div.townBox,
7170 #p-logo {
7271 left: auto;
7372 right: 0;
@@ -93,14 +92,6 @@
9493 div.tleft, div.floatleft, table.floatleft {
9594 clear: left;
9695 }
97 -div.townBox {
98 - margin-left: 0;
99 - margin-right: 1em;
100 -}
101 -div.townBox dl dd {
102 - margin-left: 0;
103 - margin-right: 1.1em;
104 -}
10596
10697 /* Fix link icons */
10798 .external {
Index: trunk/phase3/skins/simple/main.css
@@ -117,26 +117,6 @@
118118 text-align:center;
119119 }
120120
121 -div.townBox {
122 - position:relative;
123 - float:right;
124 - margin-left:1em;
125 - padding:0.3em;
126 - width: 200px;
127 - overflow: hidden;
128 - clear: right;
129 -}
130 -div.townBox dl {
131 - padding: 0;
132 - margin: 0 0 0.3em 0;
133 -}
134 -div.townBox dl dt {
135 - background: none;
136 - margin: 0.4em 0 0 0;
137 -}
138 -div.townBox dl dd {
139 - margin: 0.1em 0 0 1.1em;
140 -}
141121 .portlet {
142122 border: none;
143123 float: none;
Index: trunk/phase3/skins/chick/main.css
@@ -349,30 +349,6 @@
350350 padding:5px;
351351 font-size: 95%;
352352 }
353 -div.townBox {
354 - position:relative;
355 - float:right;
356 - background:White;
357 - margin-left:1em;
358 - border: 1px solid gray;
359 - padding:0.3em;
360 - width: 200px;
361 - overflow: hidden;
362 - clear: right;
363 -}
364 -div.townBox dl {
365 - padding: 0;
366 - margin: 0 0 0.3em 0;
367 - font-size: 96%;
368 -}
369 -div.townBox dl dt {
370 - background: none;
371 - margin: 0.4em 0 0 0;
372 -}
373 -div.townBox dl dd {
374 - margin: 0.1em 0 0 1.1em;
375 - background-color: #f3f3f3;
376 -}
377353
378354 /*
379355 ** edit views etc
Index: trunk/phase3/skins/monobook/rtl.css
@@ -68,7 +68,6 @@
6969 }
7070
7171 div.magnify,
72 -#div.townBox,
7372 #p-logo {
7473 left: auto;
7574 right: 0;
@@ -134,14 +133,6 @@
135134 div.tleft, div.floatleft, table.floatleft {
136135 clear: left;
137136 }
138 -div.townBox {
139 - margin-left: 0;
140 - margin-right: 1em;
141 -}
142 -div.townBox dl dd {
143 - margin-left: 0;
144 - margin-right: 1.1em;
145 -}
146137 #p-personal li {
147138 margin-left: 0;
148139 margin-right: 1em;
Index: trunk/phase3/skins/monobook/main.css
@@ -510,30 +510,6 @@
511511 padding: 5px;
512512 font-size: 95%;
513513 }
514 -div.townBox {
515 - position: relative;
516 - float: right;
517 - background: white;
518 - margin-left: 1em;
519 - border: 1px solid gray;
520 - padding: .3em;
521 - width: 200px;
522 - overflow: hidden;
523 - clear: right;
524 -}
525 -div.townBox dl {
526 - padding: 0;
527 - margin: 0 0 .3em;
528 - font-size: 96%;
529 -}
530 -div.townBox dl dt {
531 - background: none;
532 - margin: .4em 0 0;
533 -}
534 -div.townBox dl dd {
535 - margin: .1em 0 0 1.1em;
536 - background-color: #f3f3f3;
537 -}
538514
539515 /*
540516 ** edit views etc
@@ -550,7 +526,7 @@
551527 */
552528 #bodyContent a.external,
553529 #bodyContent a[href ^="gopher://"] {
554 - background: url(external.png) center right no-repeat;
 530+ background: url(exteg) center right no-repeat;
555531 padding-right: 13px;
556532 }
557533 #bodyContent a[href ^="https://"],
Index: trunk/phase3/skins/modern/rtl.css
@@ -20,8 +20,7 @@
2121 text-align: right;
2222 }
2323
24 -div.magnify,
25 -#div.townBox {
 24+div.magnify {
2625 left: auto;
2726 right: 0;
2827 }
@@ -43,14 +42,6 @@
4443 div.tleft, div.floatleft, table.floatleft {
4544 clear: left;
4645 }
47 -div.townBox {
48 - margin-left: 0;
49 - margin-right: 1em;
50 -}
51 -div.townBox dl dd {
52 - margin-left: 0;
53 - margin-right: 1.1em;
54 -}
5546
5647 /* Fix link icons */
5748 .external {
Index: trunk/phase3/skins/common/oldshared.css
@@ -185,30 +185,6 @@
186186 .small, .small * { font-size: 94%; }
187187 table.small { font-size: 100% }
188188
189 -div.townBox {
190 - position:relative;
191 - float:right;
192 - background:White;
193 - margin-left:1em;
194 - border: 1px solid gray;
195 - padding:0.3em;
196 - width: 200px;
197 - overflow: hidden;
198 - clear: right;
199 -}
200 -div.townBox dl {
201 - padding: 0;
202 - margin: 0 0 0.3em 0;
203 - font-size: 96%;
204 -}
205 -div.townBox dl dt {
206 - background: none;
207 - margin: 0.4em 0 0 0;
208 -}
209 -div.townBox dl dd {
210 - margin: 0.1em 0 0 1.1em;
211 - background-color: #f3f3f3;
212 -}
213189 /* use this instead of #toc for page content */
214190 .toccolours {
215191 border:1px solid #aaaaaa;
Index: trunk/phase3/skins/common/commonPrint.css
@@ -209,31 +209,6 @@
210210 img.tex { vertical-align: middle; }
211211 span.texhtml { font-family: serif; }
212212
213 -div.townBox {
214 - position:relative;
215 - float:right;
216 - background:White;
217 - margin-left:1em;
218 - border: 1px solid gray;
219 - padding:0.3em;
220 - width: 200px;
221 - overflow: hidden;
222 - clear: right;
223 -}
224 -div.townBox dl {
225 - padding: 0;
226 - margin: 0 0 0.3em 0;
227 - font-size: 96%;
228 -}
229 -div.townBox dl dt {
230 - background: none;
231 - margin: 0.4em 0 0 0;
232 -}
233 -div.townBox dl dd {
234 - margin: 0.1em 0 0 1.1em;
235 - background-color: #f3f3f3;
236 -}
237 -
238213 #siteNotice { display: none; }
239214
240215 table.gallery {
Index: trunk/phase3/RELEASE-NOTES
@@ -387,6 +387,7 @@
388388 * (bug 14537) Change interwiki name for Old Church Slavonic (cu)
389389 * (bug 14583) Fix regression in recent changes "limit to certain categories."
390390 * (bug 14515) HTML nesting cleanup on edit form
 391+* (bug 14647) Removed unused 'townBox' CSS classes
391392
392393 === API changes in 1.13 ===
393394
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1341,7 +1341,7 @@
13421342 * to ensure that client-side caches don't keep obsolete copies of global
13431343 * styles.
13441344 */
1345 -$wgStyleVersion = '158';
 1345+$wgStyleVersion = '159';
13461346
13471347
13481348 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r36679Fix regression from 36662: broke the external link icon totally, external lin...ashley16:02, 26 June 2008

Status & tagging log