r36633 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36632‎ | r36633 | r36634 >
Date:12:09, 25 June 2008
Author:raymond
Status:old
Tags:
Comment:
Fix for r36587:
* Do not overwrite the previous found $tz when $wgLocaltimezone is set
* Rename message name to a more specific one
* Add message to the message files
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2548,6 +2548,7 @@
25492549 'signatures' => array(
25502550 'signature',
25512551 'signature-anon',
 2552+ 'timezone-utc',
25522553 ),
25532554 'CoreParserFunctions' => array(
25542555 'unknown_extension_tag',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -310,6 +310,7 @@
311311 'colon-separator',
312312 'autocomment-prefix',
313313 'listgrouprights-right-display',
 314+ 'timezone-utc',
314315 );
315316
316317 /** EXIF messages, which may be set as optional in several checks, but are generally mandatory */
Index: trunk/phase3/includes/parser/Parser.php
@@ -3697,7 +3697,7 @@
36983698 * (see also bug 12815)
36993699 */
37003700 $ts = $this->mOptions->getTimestamp();
3701 - $tz = 'UTC';
 3701+ $tz = wfMsgForContent( 'timezone-utc' );
37023702 if ( isset( $wgLocaltimezone ) ) {
37033703 $unixts = wfTimestamp( TS_UNIX, $ts );
37043704 $oldtz = getenv( 'TZ' );
@@ -3706,12 +3706,7 @@
37073707 $tz = date( 'T', $unixts ); # might vary on DST changeover!
37083708 putenv( 'TZ='.$oldtz );
37093709 }
3710 -
3711 - $ctz = wfMsgForContent('timezone');
3712 - if (!wfEmptyMsg('timezone', $ctz)) {
3713 - $tz = $ctz;
3714 - }
3715 -
 3710+
37163711 $d = $wgContLang->timeanddate( $ts, false, false ) . " ($tz)";
37173712
37183713 # Variable replacement
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3375,6 +3375,7 @@
33763376 # Signatures
33773377 'signature' => '[[{{ns:user}}:$1|$2]]', # do not translate or duplicate this message to other languages
33783378 'signature-anon' => '[[{{#special:Contributions}}/$1|$2]]', # do not translate or duplicate this message to other languages
 3379+'timezone-utc' => 'UTC', # only translate this message to other languages if you have to change it
33793380
33803381 # Core parser functions
33813382 'unknown_extension_tag' => 'Unknown extension tag "$1"',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36587Patch that fixes bug number 14452. patch by AhmadSherif.alnokta22:39, 23 June 2008

Status & tagging log