r36514 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36513‎ | r36514 | r36515 >
Date:18:46, 20 June 2008
Author:demon
Status:old
Tags:
Comment:
No need to count(*) in SiteStats::admins
Modified paths:
  • /trunk/phase3/includes/SiteStats.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SiteStats.php
@@ -101,7 +101,7 @@
102102 static function admins() {
103103 if ( !isset( self::$admins ) ) {
104104 $dbr = wfGetDB( DB_SLAVE );
105 - self::$admins = $dbr->selectField( 'user_groups', 'COUNT(*)', array( 'ug_group' => 'sysop' ), __METHOD__ );
 105+ self::$admins = $dbr->selectField( 'user_groups', 'COUNT(ug_group)', array( 'ug_group' => 'sysop' ), __METHOD__ );
106106 }
107107 return self::$admins;
108108 }

Status & tagging log