r36485 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36484‎ | r36485 | r36486 >
Date:22:11, 19 June 2008
Author:brion
Status:old
Tags:
Comment:
Revert r36446, 36447 -- spews a whole bunch of table alignment into various skins' skin-specific CSS.
This seems a bit odd; if there's a reason for it *at all* it should be in the shared CSS, but I don't see any reason for it to begin with, really.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)
  • /trunk/phase3/skins/simple/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/rtl.css
@@ -195,10 +195,6 @@
196196 padding-right: 2em;
197197 }
198198
199 -.pref-label, .pref-input {
200 - text-align: right;
201 -}
202 -
203199 /* workaround for moz bug, displayed bullets on left side */
204200
205201 #toc ul {
Index: trunk/phase3/skins/monobook/main.css
@@ -1037,10 +1037,6 @@
10381038 .prefsection table, .prefsection legend {
10391039 background-color: #F9F9F9;
10401040 }
1041 -.pref-label, .pref-input {
1042 - text-align: left;
1043 - vertical-align: top;
1044 -}
10451041 .mainLegend {
10461042 display: none;
10471043 }
Index: trunk/phase3/skins/modern/rtl.css
@@ -72,10 +72,6 @@
7373 padding-right: 2em;
7474 }
7575
76 -.pref-label, .pref-input {
77 - text-align: right;
78 -}
79 -
8076 /* workaround for moz bug, displayed bullets on left side */
8177
8278 #toc ul {
Index: trunk/phase3/skins/modern/main.css
@@ -366,11 +366,6 @@
367367 font-weight: bold;
368368 }
369369
370 -.pref-label, .pref-input {
371 - text-align: left;
372 - vertical-align: top;
373 -}
374 -
375370 #preftoc li.selected {
376371 background-color: #bbbbbb;
377372 }
Index: trunk/phase3/skins/simple/rtl.css
@@ -141,10 +141,6 @@
142142 padding-right: 2em;
143143 }
144144
145 -.pref-label, .pref-input {
146 - text-align: right;
147 -}
148 -
149145 /* workaround for moz bug, displayed bullets on left side */
150146
151147 #toc ul {
Index: trunk/phase3/skins/simple/main.css
@@ -403,11 +403,6 @@
404404 margin-top: 1em;
405405 }
406406
407 -.pref-label, .pref-input {
408 - text-align: left;
409 - vertical-align: top;
410 -}
411 -
412407 #mw_trackbacks {
413408 border-style: groove;
414409 padding: 0.2em;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1341,7 +1341,7 @@
13421342 * to ensure that client-side caches don't keep obsolete copies of global
13431343 * styles.
13441344 */
1345 -$wgStyleVersion = '157';
 1345+$wgStyleVersion = '156';
13461346
13471347
13481348 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
@@ -381,7 +381,6 @@
382382 and multiple servers
383383 * (bug 14572) Redirects listed on file links on image pages no longer redirect.
384384 * (bug 14537) Change interwiki name for Old Church Slavonic (cu)
385 -* (bug 14590) Vertical align cells of Special:Preferences
386385
387386 === API changes in 1.13 ===
388387

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36446* (bug 14590) Vertical align cells of Special:Preferencesraymond09:00, 19 June 2008

Status & tagging log