r36483 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36482‎ | r36483 | r36484 >
Date:21:28, 19 June 2008
Author:brion
Status:old
Tags:
Comment:
Revert the email footer for the moment. A few comments:
* It's using the *sending* user's UI language for the footer, which is not ideal.
* There's no clean separation between body text and footer; the text will run together unappetizingly.
* The default message is really long
* "Sent automatically" implies that it's something like a "this page changed, and the computer is notifying you", but this is an explicit user-to-user messaging action, not automatic at all.
* It's trying to take the 'allowemail' toggle string, which may contain arbitrary HTML, and pop it into a plaintext email. This can cause very ugly output if formatting or character entities are being used in the message string.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEmailuser.php
@@ -150,13 +150,6 @@
151151
152152 $prefsTitle = Title::newFromText( 'Preferences', NS_SPECIAL );
153153
154 - // Add a standard footer
155 - $footerArgs[0] = $from->name;
156 - $footerArgs[1] = $to->name;
157 - $footerArgs[2] = $prefsTitle->getFullURL();
158 - $footerArgs[3] = wfMsg ('allowemail');
159 - $this->text = $this->text . "\n" . wfMsgExt( 'emailuserfooter', 'parsemag', $footerArgs );
160 -
161154 if( wfRunHooks( 'EmailUser', array( &$to, &$from, &$subject, &$this->text ) ) ) {
162155
163156 if( $wgUserEmailUseReplyTo ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2014,10 +2014,6 @@
20152015 'emailccsubject' => 'Copy of your message to $1: $2',
20162016 'emailsent' => 'E-mail sent',
20172017 'emailsenttext' => 'Your e-mail message has been sent.',
2018 -'emailuserfooter' => 'Sent automatically by {{SITENAME}} to $1 for $2.
2019 -Please note, {{SITENAME}} cannot be held responsible for the content of this email.
2020 -The option to remove yourself from these mailings is in your preferences.
2021 -Check your preferences at $3 and uncheck "$4".',
20222018
20232019 # Watchlist
20242020 'watchlist' => 'My watchlist',

Status & tagging log