r36408 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36407‎ | r36408 | r36409 >
Date:07:40, 18 June 2008
Author:aaron
Status:old
Tags:
Comment:
* There is only cuc_ip_hex for each IP, but be explicit in clause to avoid PG errors on some installs (bug 14577)
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -653,7 +653,7 @@
654654 $sql = "SELECT cuc_ip,cuc_ip_hex, COUNT(*) AS count,
655655 MIN(cuc_timestamp) AS first, MAX(cuc_timestamp) AS last
656656 FROM $cu_changes $use_index WHERE cuc_user = $user_id
657 - GROUP BY cuc_ip ORDER BY last DESC";
 657+ GROUP BY cuc_ip,cuc_ip_hex ORDER BY last DESC";
658658
659659 $ret = $dbr->query( $sql, __METHOD__ );
660660

Status & tagging log