r36370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36369‎ | r36370 | r36371 >
Date:07:31, 17 June 2008
Author:rotem
Status:old
Tags:
Comment:
Sending e-mail using Special:EmailUser does reveal the e-mail address of the sender.
Modified paths:
  • /trunk/phase3/includes/specials/Emailuser.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/Emailuser.php
@@ -149,14 +149,12 @@
150150 $subject = $this->subject;
151151
152152 $prefsTitle = Title::newFromText( 'Preferences', NS_SPECIAL );
153 - $emailTitle = Title::newFromText( 'Emailuser', NS_SPECIAL );
154153
155154 // Add a standard footer
156155 $footerArgs[0] = $wgSitename;
157156 $footerArgs[1] = $from->name;
158157 $footerArgs[2] = $to->name;
159158 $footerArgs[3] = $prefsTitle->getFullURL();
160 - $footerArgs[4] = $emailTitle->getFullURL() . '/' . urlencode( $from->name ); // Url to Special:Emailuser/Username
161159 $this->text = $this->text . "\n" . wfMsg( 'emailuserfooter', $footerArgs );
162160
163161 if( wfRunHooks( 'EmailUser', array( &$to, &$from, &$subject, &$this->text ) ) ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2017,8 +2017,7 @@
20182018 'emailuserfooter' => 'Sent automatically by $1 to $2 for $3
20192019 Please note, $1 cannot be held responsible for the content of this email.
20202020 The option to remove yourself from these mailings is in your preferences
2021 -Check your preferences at $4 and uncheck "Enable e-mail from other users."
2022 -To e-mail back without revealing your e-mail address, please use $5',
 2021+Check your preferences at $4 and uncheck "Enable e-mail from other users."',
20232022
20242023 # Watchlist
20252024 'watchlist' => 'My watchlist',

Status & tagging log