r36351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36350‎ | r36351 | r36352 >
Date:20:18, 16 June 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 4977) Fix for possible squid purging errors when using HTTP purges
and multiple servers
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SquidUpdate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SquidUpdate.php
@@ -151,8 +151,9 @@
152152 /* open the remaining sockets for this server */
153153 list($server, $port) = explode(':', $wgSquidServers[$ss]);
154154 if(!isset($port)) $port = 80;
155 - $sockets[$so+1] = @fsockopen($server, $port, $error, $errstr, 2);
156 - @stream_set_blocking($sockets[$so+1],false);
 155+ $socket = @fsockopen($server, $port, $error, $errstr, 2);
 156+ @stream_set_blocking($socket,false);
 157+ $sockets[] = $socket;
157158 }
158159 $so++;
159160 }
Index: trunk/phase3/RELEASE-NOTES
@@ -373,6 +373,8 @@
374374 * (bug 14520) Don't load nonexistent CSS files for Chick/Myskin/Simple skins
375375 * (bug 14551) Cancel upload no longer automatically suppresses warnings
376376 * (bug 13878) Deprecate Article::getDB() in favor of direct wfGetDB() calls
 377+* (bug 4977) Fix for possible squid purging errors when using HTTP purges
 378+ and multiple servers
377379
378380 === API changes in 1.13 ===
379381

Status & tagging log