r36304 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36303‎ | r36304 | r36305 >
Date:18:40, 15 June 2008
Author:aaron
Status:old
Tags:
Comment:
* Add noprint to some display items
* White spacing
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -319,11 +319,11 @@
320320
321321 # Visibility - experimental
322322 $wgHooks['userCan'][] = 'FlaggedRevs::userCanView';
 323+
323324 # Main hooks, overrides pages content, adds tags, sets tabs and permalink
324325 $wgHooks['SkinTemplateTabs'][] = 'FlaggedRevs::setActionTabs';
325326 # Change last-modified footer
326327 $wgHooks['SkinTemplateOutputPageBeforeExec'][] = 'FlaggedRevs::setLastModified';
327 -
328328 # Override current revision, add patrol links, set cache...
329329 $wgHooks['ArticleViewHeader'][] = 'FlaggedRevs::onArticleViewHeader';
330330 # Add page notice
Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -180,7 +180,7 @@
181181 $tag .= "<span id='mw-revisionratings' style='display:block;'><br/>" .
182182 wfMsgHtml('revreview-oldrating') . FlaggedRevsXML::addTagRatings( $flags ) . '</span>';
183183 }
184 - $tag = "<div id='mw-revisiontag-old' class='flaggedrevs_notice plainlinks'>$tag</div>";
 184+ $tag = "<div id='mw-revisiontag-old' class='flaggedrevs_notice plainlinks noprint'>$tag</div>";
185185 $wgOut->addHTML( $tag );
186186 }
187187 return true;
@@ -392,7 +392,7 @@
393393 $tagClass = 'flaggedrevs_basic';
394394 # Wrap tag contents in a div
395395 if( $tag !='' )
396 - $tag = "<div id='mw-revisiontag' class='$tagClass plainlinks'>$tag</div>";
 396+ $tag = "<div id='mw-revisiontag' class='$tagClass plainlinks noprint'>$tag</div>";
397397 # Set UI html
398398 $this->reviewNotice .= $tag;
399399 # Add revision notes
@@ -404,12 +404,12 @@
405405 $msg = $old ? 'revreview-quick-invalid' : 'revreview-quick-none';
406406 $tag .= "<span class='fr-icon-current plainlinks'></span>" .
407407 wfMsgExt($msg,array('parseinline'));
408 - $tag = "<div id='mw-revisiontag' class='flaggedrevs_short plainlinks'>$tag</div>";
 408+ $tag = "<div id='mw-revisiontag' class='flaggedrevs_short plainlinks noprint'>$tag</div>";
409409 $this->reviewNotice .= $tag;
410410 // Standard UI
411411 } else {
412412 $msg = $old ? 'revreview-invalid' : 'revreview-noflagged';
413 - $tag = "<div id='mw-revisiontag' class='flaggedrevs_notice plainlinks'>" .
 413+ $tag = "<div id='mw-revisiontag' class='flaggedrevs_notice plainlinks noprint'>" .
414414 wfMsgExt($msg, array('parseinline')) . "</div>";
415415 $this->reviewNotice .= $tag;
416416 }
@@ -1236,7 +1236,7 @@
12371237 $reviewTitle = SpecialPage::getTitleFor( 'RevisionReview' );
12381238 $action = $reviewTitle->getLocalUrl( 'action=submit' );
12391239 $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $action, 'id' => 'mw-reviewform' ) );
1240 - $form .= Xml::openElement( 'fieldset', array('class' => 'flaggedrevs_reviewform') );
 1240+ $form .= Xml::openElement( 'fieldset', array('class' => 'flaggedrevs_reviewform noprint') );
12411241 $form .= "<legend>" . wfMsgHtml( 'revreview-flag', $id ) . "</legend>\n";
12421242
12431243 if( $wgFlaggedRevsOverride ) {

Status & tagging log