r36257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36256‎ | r36257 | r36258 >
Date:13:22, 13 June 2008
Author:btongminh
Status:old
Tags:
Comment:
(bug 14526) Unescaped SQL in list=backlinks
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBacklinks.php
@@ -141,7 +141,7 @@
142142 $titleWhere = '';
143143 foreach($this->redirTitles as $t)
144144 $titleWhere .= ($titleWhere != '' ? " OR " : '') .
145 - "({$this->bl_title} = '{$t->getDBKey()}'" .
 145+ "({$this->bl_title} = ".$db->addQuotes($t->getDBKey()).
146146 ($this->hasNS ? " AND {$this->bl_ns} = '{$t->getNamespace()}'" : "") .
147147 ")";
148148 $this->addWhere($titleWhere);
Index: trunk/phase3/RELEASE-NOTES
@@ -444,6 +444,7 @@
445445 * Added action=emailuser to send an email to a user
446446 * (bug 14471) Use HTMLTidy and generate limit report in action=parse
447447 * (bug 14459) Added prependtext and appendtext parameters to action=edit
 448+* (bug 14526) Unescaped SQL in list=backlinks
448449
449450 === Languages updated in 1.13 ===
450451

Status & tagging log