r36203 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36202‎ | r36203 | r36204 >
Date:21:36, 11 June 2008
Author:btongminh
Status:old
Tags:
Comment:
Removed $wgEnableCascadingProtection. It was a quite pointless configuration setting which was not even properly implemented. Cascading protection has been always possible regardless of this configuration setting.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -265,8 +265,7 @@
266266 Xml::openElement( 'table', array( 'id' => 'mw-protect-table2' ) ) .
267267 Xml::openElement( 'tbody' );
268268
269 - global $wgEnableCascadingProtection;
270 - if( $wgEnableCascadingProtection && $this->mTitle->exists() ) {
 269+ if( $this->mTitle->exists() ) {
271270 $out .= '<tr>
272271 <td></td>
273272 <td class="mw-input">' .
Index: trunk/phase3/includes/Title.php
@@ -1611,16 +1611,13 @@
16121612 * The restriction array is an array of each type, each of which contains an array of unique groups
16131613 */
16141614 public function getCascadeProtectionSources( $get_pages = true ) {
1615 - global $wgEnableCascadingProtection, $wgRestrictionTypes;
 1615+ global $wgRestrictionTypes;
16161616
16171617 # Define our dimension of restrictions types
16181618 $pagerestrictions = array();
16191619 foreach( $wgRestrictionTypes as $action )
16201620 $pagerestrictions[$action] = array();
16211621
1622 - if (!$wgEnableCascadingProtection)
1623 - return array( false, $pagerestrictions );
1624 -
16251622 if ( isset( $this->mCascadeSources ) && $get_pages ) {
16261623 return array( $this->mCascadeSources, $this->mCascadingRestrictions );
16271624 } else if ( isset( $this->mHasCascadingRestrictions ) && !$get_pages ) {
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3150,11 +3150,6 @@
31513151 $wgDisableQueryPageUpdate = false;
31523152
31533153 /**
3154 - * Set this to false to disable cascading protection
3155 - */
3156 -$wgEnableCascadingProtection = true;
3157 -
3158 -/**
31593154 * Disable output compression (enabled by default if zlib is available)
31603155 */
31613156 $wgDisableOutputCompression = false;
Index: trunk/phase3/RELEASE-NOTES
@@ -56,7 +56,10 @@
5757 $wgGroupPermissions[]['noratelimit']. The former still works, however.
5858 * New $wgGroupPermissions option 'move-subpages' added to control bulk-moving
5959 subpages along with pages. Assigned to 'user' and 'sysop' by default.
60 -* New $wgRC2UDPOmitBots allows user to omit bot edits from UDP output. Default: false
 60+* New $wgRC2UDPOmitBots allows user to omit bot edits from UDP output.
 61+ Default: false
 62+* Removed $wgEnableCascadingProtection option. Disabling cascading protection
 63+ is no longer possible.
6164
6265 === New features in 1.13 ===
6366

Status & tagging log