r36187 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36186‎ | r36187 | r36188 >
Date:11:02, 11 June 2008
Author:btongminh
Status:old
Tags:
Comment:
(bug 14479) MediaWiki:upload-maxfilesize should have a div id wrapper on SpecialUpload.php
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUpload.php
@@ -1041,7 +1041,9 @@
10421042 $val2 = $val;
10431043 }
10441044 $val2 = $wgAllowCopyUploads ? min( $wgMaxUploadSize, $val2 ) : $val2;
1045 - $maxUploadSize = wfMsgExt( 'upload-maxfilesize', array( 'parseinline', 'escapenoentities' ), $wgLang->formatSize( $val2 ) );
 1045+ $maxUploadSize = Xml::tags( 'div', array( 'id' => 'mw-upload-maxfilesize' ),
 1046+ wfMsgExt( 'upload-maxfilesize', array( 'parseinline', 'escapenoentities' ),
 1047+ $wgLang->formatSize( $val2 ) ) )."\n";
10461048
10471049 $sourcefilename = wfMsgExt( 'sourcefilename', array( 'parseinline', 'escapenoentities' ) );
10481050 $destfilename = wfMsgExt( 'destfilename', array( 'parseinline', 'escapenoentities' ) );
Index: trunk/phase3/RELEASE-NOTES
@@ -358,6 +358,7 @@
359359 * (bug 14496) Fix regression with parseinline on Special:Upload.
360360 * We no longer just give up on a missing upload base directory; it's now
361361 created automatically if we have sufficient permissions!
 362+* (bug 14479) MediaWiki:upload-maxfilesize should have a div id wrapper
362363
363364
364365 === API changes in 1.13 ===

Status & tagging log