r36106 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36105‎ | r36106 | r36107 >
Date:21:01, 9 June 2008
Author:aaron
Status:old
Tags:
Comment:
Still highlight commons file versions though :)
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -795,10 +795,11 @@
796796 */
797797 public function addToFileHistLine( $historyList, $file, &$s, &$css ) {
798798 # Non-content pages cannot be validated. Stable version must exist.
799 - if( !$this->isReviewable() || !$this->getStableRev() || !$file->isLocal() )
 799+ if( !$this->isReviewable() || !$this->getStableRev() )
800800 return true;
801801 # Quality level for old versions selected all at once.
802 - if( !$file->isOld() ) {
 802+ # Commons queries cannot be done all at once...
 803+ if( !$file->isOld() || !$file->isLocal() ) {
803804 $quality = wfGetDB(DB_SLAVE)->selectField( 'flaggedrevs', 'fr_quality',
804805 array( 'fr_img_sha1' => $file->getSha1(), 'fr_img_timestamp' => $file->getTimestamp() ),
805806 __METHOD__ );

Status & tagging log