r35995 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35994‎ | r35995 | r35996 >
Date:13:18, 7 June 2008
Author:vasilievvv
Status:old
Tags:
Comment:
Disable admin deletions and umerges. They makes user to lose their accounts every day. We apparently need a proper solution for it. Account deletion was supposed to be a quick hack, but that quick hack caused infinite number of bugs (even rewriting of the whole password system was necessary to fix them), many users lost their accounts, and we still receive some weird bugs every day. I'll try to write a proper solution today or tomorrow.
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialCentralAuth.php
@@ -71,7 +71,7 @@
7272 if( $this->mPosted ) {
7373 if ( !$wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
7474 $this->showError( 'centralauth-token-mismatch' );
75 - } elseif( $this->mMethod == 'unmerge' ) {
 75+ /* } elseif( $this->mMethod == 'unmerge' ) {
7676 $status = $globalUser->adminUnattach( $this->mWikis );
7777 if ( !$status->isGood() ) {
7878 $this->showStatusError( $status->getWikiText() );
@@ -79,7 +79,7 @@
8080 global $wgLang;
8181 $this->showSuccess( 'centralauth-admin-unmerge-success',
8282 $wgLang->formatNum( $status->successCount ),
83 - /* deprecated */ $status->successCount );
 83+ */ /* deprecated */ /* $status->successCount );
8484 }
8585 } elseif ( $this->mMethod == 'delete' ) {
8686 $status = $globalUser->adminDelete();
@@ -90,7 +90,7 @@
9191 $this->showSuccess( 'centralauth-admin-delete-success', $this->mUserName );
9292 $deleted = true;
9393 $this->logAction( 'delete', $this->mUserName, $wgRequest->getVal( 'reason' ) );
94 - }
 94+ } */
9595 } elseif( $this->mMethod == 'lock' ) {
9696 $status = $globalUser->adminLock();
9797 if ( !$status->isGood() ) {
@@ -140,7 +140,7 @@
141141 $this->showUsernameForm();
142142 if ( !$deleted ) {
143143 $this->showInfo();
144 - $this->showActionForm( 'delete' );
 144+ //$this->showActionForm( 'delete' );
145145 if( !$globalUser->isLocked() && !$locked )
146146 $this->showActionForm( 'lock' );
147147 if( $globalUser->isLocked() && !$unlocked )
@@ -267,12 +267,12 @@
268268 global $wgUser;
269269 ksort( $list );
270270 return
271 - Xml::openElement( 'form',
 271+ /*Xml::openElement( 'form',
272272 array(
273273 'method' => 'post',
274274 'action' => $this->getTitle( $this->mUserName )->getLocalUrl( 'action=submit' ) ) ) .
275275 Xml::hidden( 'wpMethod', $action ) .
276 - Xml::hidden( 'wpEditToken', $wgUser->editToken() ) .
 276+ Xml::hidden( 'wpEditToken', $wgUser->editToken() ) .*/
277277 '<table>' .
278278 '<thead>' .
279279 $this->tableRow( 'th',
@@ -282,15 +282,15 @@
283283 implode( "\n",
284284 array_map( array( $this, $listMethod ),
285285 $list ) ) .
286 - '<tr>' .
 286+ /*'<tr>' .
287287 '<td></td>' .
288288 '<td>' .
289289 Xml::submitButton( $buttonText ) .
290290 '</td>' .
291 - '</tr>' .
 291+ '</tr>' .*/
292292 '</tbody>' .
293 - '</table>' .
294 - Xml::closeElement( 'form' );
 293+ '</table>' /*.
 294+ Xml::closeElement( 'form' )*/;
295295 }
296296
297297 function listMergedWikiItem( $row ) {
@@ -332,7 +332,7 @@
333333
334334 function adminCheck( $wikiID ) {
335335 return
336 - Xml::check( 'wpWikis[]', false, array( 'value' => $wikiID ) );
 336+ '';//Xml::check( 'wpWikis[]', false, array( 'value' => $wikiID ) );
337337 }
338338
339339 function showActionForm( $action ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r36089Revert to CentralAuth state as of r35994, reverting:...brion17:11, 9 June 2008

Status & tagging log