r35989 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35988‎ | r35989 | r35990 >
Date:09:02, 7 June 2008
Author:tstarling
Status:old
Tags:
Comment:
Use new calling convention for ImageGallery::add() and ImageGallery::insert()
Modified paths:
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -170,11 +170,10 @@
171171 */
172172 function addImage( Title $title, $sortkey, $pageLength, $isRedirect = false ) {
173173 if ( $this->showGallery ) {
174 - $image = wfLocalFile( $title );
175174 if( $this->flip ) {
176 - $this->gallery->insert( $image );
 175+ $this->gallery->insert( $title );
177176 } else {
178 - $this->gallery->add( $image );
 177+ $this->gallery->add( $title );
179178 }
180179 } else {
181180 $this->addPage( $title, $sortkey, $pageLength, $isRedirect );

Status & tagging log