r35897 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35896‎ | r35897 | r35898 >
Date:23:45, 4 June 2008
Author:simetrical
Status:old
Tags:
Comment:
Revert r35848 per Brion's WONTFIX of bug 14536: "This would just mean that there's no practical way to move pages with their subpages."

Rate limits should be applied per user action, *not* based on how large the effect of each action is. Note that moving a page with its talk page only counts as one move for rate limits; this is the same principle. The only point of rate limits (as far as I can think of) is to prevent unauthorized automated scripts from creating a mess in 30 seconds that it will take 10 hours to clean up by hand. Since a move with subpages is no harder to clean up (i.e., revert) than a move without subpages, they should count the same for rate limits.

Granted that at present, move with subpages *is* a little harder to revert: it requires a few more clicks, to go to the base target page and move back with subpages, as opposed to hitting a convenient revert link. But it's not 100 times as hard to clean up, and doesn't remotely deserve to be treated as such. (Unless you also want to delete the redirects, okay. I grant that reverting moves with subpages could use improvement, but killing the feature entirely for non-sysops seems unreasonable at the present time.)
Modified paths:
  • /trunk/phase3/includes/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialMovepage.php
@@ -354,12 +354,6 @@
355355 # Already did this one.
356356 continue;
357357 }
358 -
359 - if ( $wgUser->pingLimiter( 'move' ) ) {
360 - // We've hit the rate limiter.
361 - $extraOutput[] = wfMsg( 'actionthrottledtext' );
362 - break;
363 - }
364358
365359 $oldPage = Title::newFromRow( $row );
366360 $newPageName = preg_replace(

Follow-up revisions

RevisionCommit summaryAuthorDate
r36276(bug 14536) Missing database fields in selectbtongminh08:10, 14 June 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r35848Apply the rate-limiter to subpage movingwerdna06:48, 4 June 2008

Status & tagging log