r35822 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r35821‎ | r35822 | r35823 >
Date:20:58, 3 June 2008
Author:brion
Status:old
Tags:
Comment:
Move bottomscripts down to just above the </body>, outside of the globalWrapper </div>.
This seems to make JS a little more robust against horrible flaming death in MSIE -- bad HTML in site messages combined with some anonnotice DOM work has been known to cause complete page load failure.
This might also be the cause of intermittent IE 7 load failures we haven't been able to reproduce.
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
——@@ -270,9 +270,8 @@
271271 ?>
272272 </ul>
273273 </div>
274 -
275 - <?php $this->html('bottomscripts'); /* JS call to runBodyOnloadHook */ ?>
276274 </div>
 275+<?php $this->html('bottomscripts'); /* JS call to runBodyOnloadHook */ ?>
277276 <?php $this->html('reporttime') ?>
278277 <?php if ( $this->data['debug'] ): ?>
279278 <!-- Debug output:

Status & tagging log