r35700 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35699‎ | r35700 | r35701 >
Date:06:44, 2 June 2008
Author:nickj
Status:old
Tags:
Comment:
Prevent E_STRICT warning on editing a non-existent page / starting a new page:
-------------------------------
Strict Standards: Only variables should be passed by reference in includes/EditPage.php on line 2233
EditPage.showDeletionLog(Object:OutputPage) # line 685, file: includes/EditPage.php
EditPage.showIntro() # line 450, file: includes/EditPage.php
EditPage.edit() # line 348, file: includes/EditPage.php
EditPage.submit() # line 490, file: includes/Wiki.php
MediaWiki.performAction(Object:OutputPage, Object:Article, Object:Title, Object:User, Object:WebRequest) # line 59, file: includes/Wiki.php
MediaWiki.initialize(Object:Title, Object:Article, Object:OutputPage, Object:User, Object:WebRequest) # line 92, file: index.php
-------------------------------
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -24,9 +24,9 @@
2525 private $out;
2626 public $flags;
2727
28 - function __construct( &$skin, &$out, $flags = 0 ) {
29 - $this->skin =& $skin;
30 - $this->out =& $out;
 28+ function __construct( $skin, $out, $flags = 0 ) {
 29+ $this->skin = $skin;
 30+ $this->out = $out;
3131 $this->flags = $flags;
3232 $this->preCacheMessages();
3333 }

Status & tagging log