r35516 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35515‎ | r35516 | r35517 >
Date:19:51, 28 May 2008
Author:raymond
Status:old
Tags:
Comment:
* (bug 14146) Wrap usage section on imagepages into <div>s.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -647,6 +647,7 @@
648648 $wgOut->addWikiMsg( 'nolinkstoimage' );
649649 return;
650650 }
 651+ $wgOut->addHTML( "<div id='mw-imagepage-section-linkstoimage'>\n" );
651652 $wgOut->addWikiMsg( 'linkstoimage' );
652653 $wgOut->addHTML( "<ul class='mw-imagepage-linktoimage'>\n" );
653654
@@ -661,7 +662,7 @@
662663 $wgOut->addHTML( "<li>{$link}</li>\n" );
663664 }
664665 }
665 - $wgOut->addHTML( "</ul>\n" );
 666+ $wgOut->addHTML( "</ul></div>\n" );
666667 $res->free();
667668
668669 // Add a links to [[Special:Whatlinkshere]]
@@ -675,8 +676,8 @@
676677
677678 $redirects = $this->getTitle()->getRedirectsHere( NS_IMAGE );
678679 if ( count( $redirects ) == 0 ) return;
679 -
680680
 681+ $wgOut->addHTML( "<div id='mw-imagepage-section-redirectstofile'>\n" );
681682 $wgOut->addWikiMsg( 'redirectstofile' );
682683 $wgOut->addHTML( "<ul class='mw-imagepage-redirectstofile'>\n" );
683684
@@ -685,7 +686,7 @@
686687 $link = $sk->makeKnownLinkObj( $title, "" );
687688 $wgOut->addHTML( "<li>{$link}</li>\n" );
688689 }
689 - $wgOut->addHTML( "</ul>\n" );
 690+ $wgOut->addHTML( "</ul></div>\n" );
690691
691692 }
692693
@@ -697,6 +698,7 @@
698699 $dupes = $this->getDuplicates();
699700 if ( count( $dupes ) == 0 ) return;
700701
 702+ $wgOut->addHTML( "<div id='mw-imagepage-section-duplicates'>\n" );
701703 $wgOut->addWikiMsg( 'duplicatesoffile' );
702704 $wgOut->addHTML( "<ul class='mw-imagepage-duplicates'>\n" );
703705
@@ -709,7 +711,7 @@
710712 $file->getTitle()->getPrefixedText() );
711713 $wgOut->addHTML( "<li>{$link}</li>\n" );
712714 }
713 - $wgOut->addHTML( "</ul>\n" );
 715+ $wgOut->addHTML( "</ul></div>\n" );
714716 }
715717
716718 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -130,6 +130,7 @@
131131 * (bug 14259) Localisation message for upload button on Special:Import is now
132132 'import-upload' instead of 'upload'
133133 * Add information about user group membership to Special:Preferences
 134+* (bug 14146) Wrap usage section on imagepages into <div>s.
134135
135136 === Bug fixes in 1.13 ===
136137

Follow-up revisions

RevisionCommit summaryAuthorDate
r35527* (bug 14146) Wrap usage section on imagepages into <div>s....raymond03:44, 29 May 2008

Status & tagging log