r35232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35231‎ | r35232 | r35233 >
Date:16:51, 23 May 2008
Author:aaron
Status:old
Tags:
Comment:
No need to explicitly give page_id
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -2000,12 +2000,11 @@
20012001
20022002 static function addToHistQuery( $pager, &$queryInfo ) {
20032003 $flaggedArticle = FlaggedArticle::getInstance( $pager->mPageHistory->getTitle() );
2004 - $pageID = $pager->mPageHistory->getTitle()->getArticleId();
20052004 if( $flaggedArticle->isReviewable() ) {
20062005 $queryInfo['tables'][] = 'flaggedrevs';
20072006 $queryInfo['fields'][] = 'fr_quality';
20082007 $queryInfo['fields'][] = 'fr_user';
2009 - $queryInfo['join_conds']['flaggedrevs'] = array( 'LEFT JOIN', "fr_page_id = {$pageID} AND fr_rev_id = rev_id" );
 2008+ $queryInfo['join_conds']['flaggedrevs'] = array( 'LEFT JOIN', "fr_page_id = rev_page AND fr_rev_id = rev_id" );
20102009 }
20112010 return true;
20122011 }

Status & tagging log