r35219 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35218‎ | r35219 | r35220 >
Date:07:33, 23 May 2008
Author:aaron
Status:old
Tags:
Comment:
Remove shitty ass useless fucking ampersands that just make it harder to avoid fucking strict notices
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
@@ -58,7 +58,7 @@
5959 * @access public
6060 * @static
6161 */
62 - public static function loadFromId( &$db, $id ) {
 62+ public static function loadFromId( $db, $id ) {
6363 return Revision::loadFromConds( $db,
6464 array( 'page_id=rev_page',
6565 'rev_id' => intval( $id ) ) );
@@ -98,7 +98,7 @@
9999 * @access public
100100 * @static
101101 */
102 - public static function loadFromTitle( &$db, $title, $id = 0 ) {
 102+ public static function loadFromTitle( $db, $title, $id = 0 ) {
103103 if( $id ) {
104104 $matchId = intval( $id );
105105 } else {
@@ -124,7 +124,7 @@
125125 * @access public
126126 * @static
127127 */
128 - public static function loadFromTimestamp( &$db, &$title, $timestamp ) {
 128+ public static function loadFromTimestamp( $db, $title, $timestamp ) {
129129 return Revision::loadFromConds(
130130 $db,
131131 array( 'rev_timestamp' => $db->timestamp( $timestamp ),
@@ -185,7 +185,7 @@
186186 * @access public
187187 * @static
188188 */
189 - public static function fetchAllRevisions( &$title ) {
 189+ public static function fetchAllRevisions( $title ) {
190190 return Revision::fetchFromConds(
191191 wfGetDB( DB_SLAVE ),
192192 array( 'page_namespace' => $title->getNamespace(),
@@ -203,7 +203,7 @@
204204 * @access public
205205 * @static
206206 */
207 - public static function fetchRevision( &$title ) {
 207+ public static function fetchRevision( $title ) {
208208 return Revision::fetchFromConds(
209209 wfGetDB( DB_SLAVE ),
210210 array( 'rev_id=page_latest',
@@ -710,7 +710,7 @@
711711 * @param Database $dbw
712712 * @return int
713713 */
714 - public function insertOn( &$dbw ) {
 714+ public function insertOn( $dbw ) {
715715 global $wgDefaultExternalStore;
716716
717717 wfProfileIn( __METHOD__ );
@@ -850,7 +850,7 @@
851851 * @param bool $minor
852852 * @return Revision
853853 */
854 - public static function newNullRevision( &$dbw, $pageId, $summary, $minor ) {
 854+ public static function newNullRevision( $dbw, $pageId, $summary, $minor ) {
855855 wfProfileIn( __METHOD__ );
856856
857857 $current = $dbw->selectRow(

Status & tagging log