r35210 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35209‎ | r35210 | r35211 >
Date:22:49, 22 May 2008
Author:aaron
Status:old
Tags:
Comment:
* Use $limit = min( $wgFeedLimit, $limit ); to shorten things
* Add comment
Modified paths:
  • /trunk/phase3/includes/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialRecentchanges.php
@@ -56,10 +56,7 @@
5757 # As a feed, use limited settings only
5858 if( $feedFormat ) {
5959 global $wgFeedLimit;
60 - if( $limit > $wgFeedLimit ) {
61 - $limit = $wgFeedLimit;
62 - }
63 -
 60+ $limit = min( $wgFeedLimit, $limit );
6461 } else {
6562
6663 $namespace = $wgRequest->getIntOrNull( 'namespace' );
@@ -509,6 +506,7 @@
510507 if ($more != '') $more .= '&';
511508
512509 # Sort data for display and make sure it's unique after we've added user data.
 510+ # FIXME: why does this piss around with globals like this? Why is $limit added on globally?
513511 $wgRCLinkLimits[] = $limit;
514512 $wgRCLinkDays[] = $days;
515513 sort($wgRCLinkLimits);

Status & tagging log