r35127 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r35126‎ | r35127 | r35128 >
Date:02:45, 21 May 2008
Author:aaron
Status:old
Tags:
Comment:
No need to check $rev twice
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -2044,7 +2044,7 @@
20452045 $p['uniqueContentPages'] = isset($p['uniqueContentPages']) ? $p['uniqueContentPages'] : '';
20462046 $p['totalContentEdits'] = isset($p['totalContentEdits']) ? $p['totalContentEdits'] : 0;
20472047 $p['editComments'] = isset($p['editComments']) ? $p['editComments'] : 0;
2048 - if( $rev && $article->getTitle()->isContentPage() ) {
 2048+ if( $article->getTitle()->isContentPage() ) {
20492049 $pages = explode( ',', trim($p['uniqueContentPages']) ); // page IDs
20502050 # Don't let this get bloated for no reason
20512051 if( count($pages) < $wgFlaggedRevsAutopromote['uniqueContentPages'] && !in_array($article->getId(),$pages) ) {

Status & tagging log