r34986 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34985‎ | r34986 | r34987 >
Date:17:48, 17 May 2008
Author:aaron
Status:old
Tags:
Comment:
pass by ref errors
Modified paths:
  • /trunk/phase3/includes/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialRecentchanges.php
@@ -511,8 +511,8 @@
512512 # Sort data for display and make sure it's unique after we've added user data.
513513 $wgRCLinkLimits[] = $limit;
514514 $wgRCLinkDays[] = $days;
515 - sort(&$wgRCLinkLimits);
516 - sort(&$wgRCLinkDays);
 515+ sort($wgRCLinkLimits);
 516+ sort($wgRCLinkDays);
517517 $wgRCLinkLimits = array_unique($wgRCLinkLimits);
518518 $wgRCLinkDays = array_unique($wgRCLinkDays);
519519
@@ -579,8 +579,8 @@
580580 # Sort data for display and make sure it's unique after we've added user data.
581581 $wgRCLinkLimits[] = $options['limit'];
582582 $wgRCLinkDays[] = $options['days'];
583 - sort(&$wgRCLinkLimits);
584 - sort(&$wgRCLinkDays);
 583+ sort($wgRCLinkLimits);
 584+ sort($wgRCLinkDays);
585585 $wgRCLinkLimits = array_unique($wgRCLinkLimits);
586586 $wgRCLinkDays = array_unique($wgRCLinkDays);
587587

Status & tagging log