r34979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34978‎ | r34979 | r34980 >
Date:14:07, 17 May 2008
Author:ashley
Status:old
Tags:
Comment:
Imagetabs:
*standard coding style
*proper copyright symbol as per http://en.wikipedia.org/wiki/Copyright_symbol
Modified paths:
  • /trunk/extensions/Imagetabs/imagetabs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Imagetabs/imagetabs.php
@@ -6,7 +6,7 @@
77 * (at your option) any later version.
88 *
99 * @author Roan Kattouw <roan.kattouw@home.nl>
10 - * @copyright Copyright (C) 2007 Roan Kattouw
 10+ * @copyright Copyright © 2007 Roan Kattouw
1111 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License
1212 *
1313 * An extension that shows interwiki tabs above Image: pages
@@ -19,26 +19,22 @@
2020 $wgExtensionFunctions[] = 'createImageTabs_setup';
2121 $wgExtensionCredits['other'][] = array(
2222 'name' => 'Imagetabs',
23 - 'author' => 'Joe Beaudoin Jr. and Roan Kattouw',
 23+ 'author' => array('Joe Beaudoin Jr.', 'Roan Kattouw'),
2424 'description' => 'Adds tabs with interwiki links above Image: pages',
2525 'version' => '1.0',
2626 'url' => 'http://www.mediawiki.org/wiki/Extension:Imagetabs'
2727 );
2828
29 -function createImageTabs_setup()
30 -{
 29+function createImageTabs_setup() {
3130 global $wgHooks;
3231 $wgHooks['SkinTemplateContentActions'][] = 'createImageTabs_hook';
3332 }
3433
35 -function createImageTabs_hook(&$content_actions)
36 -{
 34+function createImageTabs_hook(&$content_actions) {
3735 global $wgEnableInterwikiImageTabs, $wgInterwikiImageTabs, $wgTitle, $wgLocalInterwiki;
38 - if($wgEnableInterwikiImageTabs && $wgTitle->getNamespace() == NS_IMAGE)
39 - {
 36+ if($wgEnableInterwikiImageTabs && $wgTitle->getNamespace() == NS_IMAGE) {
4037 $i = 0;
41 - foreach($wgInterwikiImageTabs as $prefix => $caption)
42 - {
 38+ foreach($wgInterwikiImageTabs as $prefix => $caption) {
4339 // Go to prefix:Image:title. Image: is automatically translated if necessary.
4440 $titleObj = Title::newFromText($prefix . ":Image:" . $wgTitle->getText());
4541 // Check that we don't link to ourselves
@@ -51,4 +47,4 @@
5248 }
5349 }
5450 return true;
55 -}
 51+}
\ No newline at end of file

Status & tagging log