r34821 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34820‎ | r34821 | r34822 >
Date:18:12, 14 May 2008
Author:raymond
Status:old
Tags:
Comment:
Remove old compatibility code (pre 1.10).
Not longer needed as extensions are branched with every new core release.
Modified paths:
  • /trunk/extensions/Newuserlog/Newuserlog.i18n.php (modified) (history)
  • /trunk/extensions/Newuserlog/Newuserlog.php (modified) (history)
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Newuserlog/Newuserlog.php
@@ -27,7 +27,7 @@
2828 $wgLogTypes[] = 'newusers';
2929 $wgLogNames['newusers'] = 'newuserlogpage';
3030 $wgLogHeaders['newusers'] = 'newuserlogpagetext';
31 -$wgLogActions['newusers/newusers'] = 'newuserlogentry';
 31+$wgLogActions['newusers/newusers'] = 'newuserlogentry'; // For compatibility with older log entries
3232 $wgLogActions['newusers/create'] = 'newuserlog-create-entry';
3333 $wgLogActions['newusers/create2'] = 'newuserlog-create2-entry';
3434 $wgLogActions['newusers/autocreate'] = 'newuserlog-autocreate-entry';
@@ -58,22 +58,12 @@
5959 } else {
6060 // Links not necessary for self-creations, they will appear already in
6161 // recentchanges and special:log view for the creating user.
62 - // For compatability: From 1.10alpha the 'user tools' are used at special:log
63 - // see bug 4756: Long usernames break block link in new user log entries
6462
6563 wfLoadExtensionMessages( 'Newuserlog' );
6664 $contribs = wfMsgForContent( 'contribslink' );
6765 $block = wfMsgForContent( 'blocklink' );
6866 $action = 'create2';
69 - $message = '';
70 - if ( version_compare( $wgVersion, '1.10alpha', '>=' ) ) {
71 - if( $byEmail ) {
72 - $message = wfMsgForContent( 'newuserlog-byemail' );
73 - }
74 - } else {
75 - $message = wfMsgForContent( 'newuserlog-create-text',
76 - $user->getName(), $talk, $contribs, $block );
77 - }
 67+ $message = $byEmail ? wfMsgForContent( 'newuserlog-byemail' ) : '';
7868 }
7969
8070 $log = new LogPage( 'newusers' );
Index: trunk/extensions/Newuserlog/Newuserlog.i18n.php
@@ -8,15 +8,14 @@
99 $messages = array();
1010
1111 $messages['en'] = array(
12 - 'newuserlogpage' => 'User creation log',
13 - 'newuserlogpagetext' => 'This is a log of user creations',
14 - 'newuserlog-desc' => 'Adds a [[Special:Log/newusers|log of account creations]] to [[Special:Log]]',
15 - 'newuserlogentry' => '', # For compatibility, do not translate this
16 - 'newuserlog-byemail' => 'password sent by e-mail',
17 - 'newuserlog-create-entry' => 'New user',
18 - 'newuserlog-create2-entry' => 'created account for $1',
 12+ 'newuserlogpage' => 'User creation log',
 13+ 'newuserlogpagetext' => 'This is a log of user creations',
 14+ 'newuserlog-desc' => 'Adds a [[Special:Log/newusers|log of account creations]] to [[Special:Log]]',
 15+ 'newuserlogentry' => '', # For compatibility, do not translate this
 16+ 'newuserlog-byemail' => 'password sent by e-mail',
 17+ 'newuserlog-create-entry' => 'New user',
 18+ 'newuserlog-create2-entry' => 'created account for $1',
1919 'newuserlog-autocreate-entry' => 'Account created automatically',
20 - 'newuserlog-create-text' => "[[User talk:$1|$2]] | [[Special:Contributions/$1|$3]] | [[Special:Blockip/$1|$4]]", # For compatibility <= MW 1.9, do not translate this
2120 );
2221
2322 $messages['af'] = array(
Index: trunk/extensions/Translate/MessageGroups.php
@@ -1840,7 +1840,6 @@
18411841
18421842 protected $ignored = array(
18431843 'newuserlogentry',
1844 - 'newuserlog-create-text',
18451844 );
18461845 }
18471846

Status & tagging log