r34696 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r34695‎ | r34696 | r34697 >
Date:23:09, 12 May 2008
Author:brion
Status:old
Tags:
Comment:
Revert r34585: "Normalise also special page names (in addition to namespace)"
Unclear what it's meant to accomplish, but it appears to break at least the AJAX search on special page list. Unable to get it to jump through the list properly, probably due to being impossible to work with a Title object with an arbitrary name, so it's impossible to jump partway into the list.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
——@@ -2180,13 +2180,6 @@
21812181 return false;
21822182 }
21832183
2184 - // Normalise special page names
2185 - if ( $this->mNamespace == NS_SPECIAL ) {
2186 - list( $name, $subpage ) = SpecialPage::resolveAliasWithSubpage( $dbkey );
2187 - $dbkey = SpecialPage::getLocalNameFor( $name, $subpage );
2188 - }
2189 -
2190 -
21912184 # Fill fields
21922185 $this->mDbkeyform = $dbkey;
21932186 $this->mUrlform = wfUrlencode( $dbkey );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34585* Normalise also special page names (in addition to namespace)nikerabbit15:14, 10 May 2008

Status & tagging log