r34659 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34658‎ | r34659 | r34660 >
Date:13:56, 12 May 2008
Author:simetrical
Status:old
Tags:
Comment:
Tweaks to Special:ListGroupRights:
* Have the internally-used permission key in parentheses after the descriptive text, since a primary purpose of the page is for sysadmins' convenience.
* Make sure to use the word "rollback" in rollback-related messages -- that's the name of the button, after all.
* Adjust the wording of a couple of other messages so they sound better or are clearer.
Modified paths:
  • /trunk/phase3/includes/SpecialListgrouprights.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1292,6 +1292,7 @@
12931293 'listgrouprights-rights',
12941294 'listgrouprights-helppage',
12951295 'listgrouprights-members',
 1296+ 'listgrouprights-right-display',
12961297 ),
12971298 'emailuser' => array(
12981299 'mailnologin',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -279,6 +279,7 @@
280280 'comma-separator',
281281 'colon-separator',
282282 'autocomment-prefix',
 283+ 'listgrouprights-right-display',
283284 );
284285
285286 /** EXIF messages, which may be set as optional in several checks, but are generally mandatory */
Index: trunk/phase3/includes/SpecialListgrouprights.php
@@ -95,7 +95,10 @@
9696 $r = array();
9797 foreach( $permissions as $permission => $granted ) {
9898 if ( $granted ) {
99 - $description = User::getRightDescription($permission);
 99+ $description = wfMsgHTML( 'listgrouprights-right-display',
 100+ User::getRightDescription($permission),
 101+ $permission
 102+ );
100103 $r[] = $description;
101104 }
102105 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1469,10 +1469,10 @@
14701470 'right-suppressredirect' => 'Not create a redirect from the old name when moving a page',
14711471 'right-upload' => 'Upload files',
14721472 'right-reupload' => 'Overwrite an existing file',
1473 -'right-reupload-own' => 'Overwrite an existing file uploaded by the same user',
 1473+'right-reupload-own' => 'Overwrite an existing file uploaded by oneself',
14741474 'right-reupload-shared' => 'Override files on the shared media repository locally',
14751475 'right-upload_by_url' => 'Upload a file from a URL address',
1476 -'right-purge' => 'Purge the site cache for a page without a confirmation page',
 1476+'right-purge' => 'Purge the site cache for a page without confirmation',
14771477 'right-autoconfirmed' => 'Edit semi-protected pages',
14781478 'right-bot' => 'Be treated as an automated process',
14791479 'right-nominornewtalk' => 'Not have minor edits to discussion pages trigger the new messages prompt',
@@ -1494,18 +1494,18 @@
14951495 'right-editprotected' => 'Edit protected pages (without cascading protection)',
14961496 'right-editinterface' => 'Edit the user interface',
14971497 'right-editusercssjs' => "Edit other users' CSS and JS files",
1498 -'right-rollback' => 'Quickly revert the last user who edited a particular page',
1499 -'right-markbotedits' => 'Mark reverted edits as bot edits',
 1498+'right-rollback' => 'Quickly rollback the edits of the last user who edited a particular page',
 1499+'right-markbotedits' => 'Mark rolled-back edits as bot edits',
15001500 'right-import' => 'Import pages from other wikis',
15011501 'right-importupload' => 'Import pages from a file upload',
1502 -'right-patrol' => 'Mark edits as patrolled',
1503 -'right-autopatrol' => 'Have edits automatically marked as patrolled',
 1502+'right-patrol' => "Mark others' edits as patrolled",
 1503+'right-autopatrol' => "Have one's own edits automatically marked as patrolled",
15041504 'right-patrolmarks' => 'View recent changes patrol marks',
15051505 'right-unwatchedpages' => 'View a list of unwatched pages',
15061506 'right-trackback' => 'Submit a trackback',
15071507 'right-mergehistory' => 'Merge the history of pages',
15081508 'right-userrights' => 'Edit all user rights',
1509 -'right-userrights-interwiki' => 'Edit user rights of users in other wiki sites',
 1509+'right-userrights-interwiki' => 'Edit user rights of users on other wikis',
15101510 'right-siteadmin' => 'Lock and unlock the database',
15111511
15121512 # User rights log
@@ -1958,13 +1958,14 @@
19591959 'listusers-noresult' => 'No user found.',
19601960
19611961 # Special:Listgrouprights
1962 -'listgrouprights' => 'User group rights',
1963 -'listgrouprights-summary' => 'The following is a list of user groups defined on this wiki, with their associated access rights.
1964 -Additional information about individual rights can be found [[{{MediaWiki:Listgrouprights-helppage}}|here]].',
1965 -'listgrouprights-group' => 'Group',
1966 -'listgrouprights-rights' => 'Rights',
1967 -'listgrouprights-helppage' => 'Help:Group rights',
1968 -'listgrouprights-members' => '(list of members)',
 1962+'listgrouprights' => 'User group rights',
 1963+'listgrouprights-summary' => 'The following is a list of user groups defined on this wiki, with their associated access rights.
 1964+Additional information about individual rights can be found at [[{{MediaWiki:Listgrouprights-helppage}}]].',
 1965+'listgrouprights-group' => 'Group',
 1966+'listgrouprights-rights' => 'Rights',
 1967+'listgrouprights-helppage' => 'Help:Group rights',
 1968+'listgrouprights-members' => '(list of members)',
 1969+'listgrouprights-right-display' => '$1 ($2)', # only translate this message to other languages if you have to change it
19691970
19701971 # E-mail user
19711972 'mailnologin' => 'No send address',

Status & tagging log