r34640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34639‎ | r34640 | r34641 >
Date:04:50, 12 May 2008
Author:aaron
Status:old
Tags:
Comment:
Add br tags back
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsXML.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevsXML.php
@@ -49,8 +49,9 @@
5050 global $wgFlaggedRevTags;
5151
5252 $tag = '';
53 - if( $prettyBox )
 53+ if( $prettyBox ) {
5454 $tag .= "<table id='mw-revisionratings-box' align='center' class='$css' cellpadding='0'>";
 55+ }
5556 foreach( FlaggedRevs::$dimensions as $quality => $value ) {
5657 $level = isset( $flags[$quality] ) ? $flags[$quality] : 0;
5758 $encValueText = wfMsgHtml("revreview-$quality-$level");
@@ -75,9 +76,9 @@
7677 "</span>\n";
7778 }
7879 }
79 - if( $prettyBox )
 80+ if( $prettyBox ) {
8081 $tag .= '</table>';
81 -
 82+ }
8283 return $tag;
8384 }
8485
Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -120,7 +120,7 @@
121121 $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
122122 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
123123 wfMsg( 'revreview-toggle' ) . "</span>";
124 - $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
 124+ $tag .= "<span id='mw-revisionratings' style='display:block;'><br/>" .
125125 wfMsgHtml('revreview-oldrating') . FlaggedRevsXML::addTagRatings( $flags ) . '</span>';
126126 }
127127 $tag = "<div id='mw-revisiontag-old' class='flaggedrevs_notice plainlinks'>$tag</div>";
@@ -192,7 +192,7 @@
193193 $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
194194 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
195195 wfMsg( 'revreview-toggle' ) . "</span>";
196 - $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
 196+ $tag .= "<span id='mw-revisionratings' style='display:block;'><br/>" .
197197 wfMsgHtml('revreview-oldrating') . FlaggedRevsXML::addTagRatings( $flags ) . '</span>';
198198 }
199199 }
@@ -260,7 +260,7 @@
261261 $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
262262 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
263263 wfMsg( 'revreview-toggle' ) . "</span>";
264 - $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
 264+ $tag .= "<span id='mw-revisionratings' style='display:block;'><br/>" .
265265 wfMsgHtml('revreview-oldrating') . FlaggedRevsXML::addTagRatings( $flags ) . '</span>';
266266 }
267267 }
@@ -305,7 +305,7 @@
306306 $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
307307 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
308308 wfMsg('revreview-toggle') . "</span>";
309 - $tag .= "<span id='mw-revisionratings' style='display:block;'>" .
 309+ $tag .= "<span id='mw-revisionratings' style='display:block;'><br/>" .
310310 FlaggedRevsXML::addTagRatings( $flags ) . '</span>';
311311 }
312312 }
@@ -441,7 +441,7 @@
442442 $tag .= " <span id='mw-revisiontoggle' class='flaggedrevs_toggle' style='display:none;'" .
443443 " onclick='toggleRevRatings()' title='" . wfMsgHtml('revreview-toggle-title') . "' >" .
444444 wfMsg( 'revreview-toggle' ) . "</span>";
445 - $tag .= '<span id="mw-revisionratings" style="display:block;">' .
 445+ $tag .= '<span id="mw-revisionratings" style="display:block;"><br/>' .
446446 wfMsg('revreview-oldrating') . FlaggedRevsXML::addTagRatings( $flags ) . '</span>';
447447 }
448448 $tag = "<div id='mw-revisiontag-edit' class='flaggedrevs_editnotice plainlinks'>$tag</div>";

Status & tagging log