Index: trunk/phase3/includes/SpecialUpload.php |
— | — | @@ -900,6 +900,11 @@ |
901 | 901 | $useAjaxDestCheck = $wgUseAjax && $wgAjaxUploadDestCheck; |
902 | 902 | $useAjaxLicensePreview = $wgUseAjax && $wgAjaxLicensePreview; |
903 | 903 | |
| 904 | + // Initilaize $extensionList here in case it is not set later on |
| 905 | + // (which would cause a E_NOTICE) and it must not be set only if it |
| 906 | + // isn't set to avoid a possible register_globals issue. |
| 907 | + $extensionList = ''; |
| 908 | + |
904 | 909 | $adc = wfBoolToStr( $useAjaxDestCheck ); |
905 | 910 | $alp = wfBoolToStr( $useAjaxLicensePreview ); |
906 | 911 | $autofill = wfBoolToStr( $this->mDesiredDestName == '' ); |
— | — | @@ -1059,10 +1064,6 @@ |
1060 | 1065 | |
1061 | 1066 | $encComment = htmlspecialchars( $this->mComment ); |
1062 | 1067 | |
1063 | | - if( !isset( $extensionsList ) ) { |
1064 | | - $extensionsList = ''; |
1065 | | - } |
1066 | | - |
1067 | 1068 | $wgOut->addHTML( |
1068 | 1069 | Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL(), |
1069 | 1070 | 'enctype' => 'multipart/form-data', 'id' => 'mw-upload-form' ) ) . |