r34553 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34552‎ | r34553 | r34554 >
Date:09:16, 10 May 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Some message tweaks
Modified paths:
  • /trunk/phase3/includes/media/Generic.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Generic.php
@@ -416,10 +416,14 @@
417417 function getDimensionsString( $file ) {
418418 global $wgLang;
419419 $pages = $file->pageCount();
 420+ $width = $wgLang->formatNum( $file->getWidth() );
 421+ $height = $wgLang->formatNum( $file->getHeight() );
 422+ $pagesFmt = $wgLang->formatNum( $pages )
 423+
420424 if ( $pages > 1 ) {
421 - return wfMsg( 'widthheightpage', $wgLang->formatNum( $file->getWidth() ), $wgLang->formatNum( $file->getHeight() ), $wgLang->formatNum( $pages ) );
 425+ return wfMsgExt( 'widthheightpage', 'parsemag', $width, $height, $pagesFmt );
422426 } else {
423 - return wfMsg( 'widthheight', $wgLang->formatNum( $file->getWidth() ), $wgLang->formatNum( $file->getHeight() ) );
 427+ return wfMsg( 'widthheight', $width, $height );
424428 }
425429 }
426430 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1476,7 +1476,7 @@
14771477 'right-autoconfirmed' => 'Edit semi-protected pages',
14781478 'right-bot' => 'Be treated as an automated process',
14791479 'right-nominornewtalk' => 'Not have minor edits to discussion pages trigger the new messages prompt',
1480 -'right-apihighlimits' => 'Use API high limits',
 1480+'right-apihighlimits' => 'Use higher limits in API queries',
14811481 'right-delete' => 'Delete pages',
14821482 'right-bigdelete' => 'Delete pages with large histories',
14831483 'right-deleterevision' => 'Delete and undelete specific revisions of pages',
@@ -1714,7 +1714,7 @@
17151715 'redirectstofile' => 'The following files redirect to this file:',
17161716 'sharedupload' => 'This file is a shared upload and may be used by other projects.',
17171717 'shareduploadwiki' => 'Please see the $1 for further information.',
1718 -'shareduploadwiki-desc' => 'The description on its $1 there is shown below.',
 1718+'shareduploadwiki-desc' => 'The description on its $1 on the shared repository is shown below.',
17191719 'shareduploadwiki-linktext' => 'file description page',
17201720 'shareddescriptionfollows' => '-', # do not translate or duplicate this message to other languages
17211721 'shareduploadduplicate' => 'This file is a duplicate of $1 from shared repository.',
@@ -2713,7 +2713,7 @@
27142714 'imagemaxsize' => 'Limit images on file description pages to:',
27152715 'thumbsize' => 'Thumbnail size:',
27162716 'widthheight' => '$1×$2', # only translate this message to other languages if you have to change it
2717 -'widthheightpage' => '$1×$2, $3 pages',
 2717+'widthheightpage' => '$1×$2, $3 {{PLURAL:$3|page|pages}}',
27182718 'file-info' => '(file size: $1, MIME type: $2)',
27192719 'file-info-size' => '($1 × $2 pixel, file size: $3, MIME type: $4)',
27202720 'file-nohires' => '<small>No higher resolution available.</small>',

Status & tagging log