r34537 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r34536‎ | r34537 | r34538 >
Date:22:21, 9 May 2008
Author:rainman
Status:old
Tags:
Comment:
The Horrible Twin for r28127. The call happens when content is fetched from
parser cache, and the title needs converting. A consequence of returning ''
is bad regexp that produces odd conversion behavior for titles reported on
various occasions.

One of these days, I'm just going to completely rewrite this thing, I swear!
Modified paths:
  • /trunk/phase3/languages/LanguageConverter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/LanguageConverter.php
——@@ -168,7 +168,7 @@
169169 3. place holders created by the parser
170170 */
171171 global $wgParser;
172 - if (isset($wgParser))
 172+ if (isset($wgParser) && $wgParser->UniqPrefix()!='')
173173 $marker = '|' . $wgParser->UniqPrefix() . '[\-a-zA-Z0-9]+';
174174 else
175175 $marker = "";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r28127@fixme this is probably *horribly wrong*...brion20:38, 3 December 2007

Status & tagging log