r34441 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34440‎ | r34441 | r34442 >
Date:15:50, 8 May 2008
Author:catrope
Status:old
Tags:
Comment:
(bug 14042) Calling Database::limitResult() misplaced the comment in the log file
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Database.php
@@ -1668,7 +1668,7 @@
16691669 if( !is_numeric($limit) ) {
16701670 throw new DBUnexpectedError( $this, "Invalid non-numeric limit passed to limitResult()\n" );
16711671 }
1672 - return " $sql LIMIT "
 1672+ return "$sql LIMIT "
16731673 . ( (is_numeric($offset) && $offset != 0) ? "{$offset}," : "" )
16741674 . "{$limit} ";
16751675 }
Index: trunk/phase3/RELEASE-NOTES
@@ -261,6 +261,7 @@
262262 * (bug 13615) Update case mappings and normalization to Unicode 5.1.0
263263 Note that case mappings will only be used if mbstring extension is not present.
264264 * (bug 14044) Don't increment page view counters on views from bot users
 265+* (bug 14042) Calling Database::limitResult() misplaced the comment in the log file
265266
266267 === API changes in 1.13 ===
267268

Status & tagging log