r34393 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34392‎ | r34393 | r34394 >
Date:19:17, 7 May 2008
Author:rotem
Status:old
Tags:
Comment:
This should probably be restricted to users with the 'hiderevision' right, as the 'suppress' right is only about viewing the suppression log and hidden users.
Modified paths:
  • /trunk/phase3/includes/SpecialUndelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUndelete.php
@@ -587,7 +587,7 @@
588588 $this->mPreview = $request->getCheck( 'preview' ) && $posted;
589589 $this->mDiff = $request->getCheck( 'diff' );
590590 $this->mComment = $request->getText( 'wpComment' );
591 - $this->mUnsuppress = $request->getVal( 'wpUnsuppress' ) && $wgUser->isAllowed( 'suppress' );
 591+ $this->mUnsuppress = $request->getVal( 'wpUnsuppress' ) && $wgUser->isAllowed( 'hiderevision' );
592592
593593 if( $par != "" ) {
594594 $this->mTarget = $par;
@@ -966,7 +966,7 @@
967967 if( $this->mAllowed && ( $haveRevisions || $haveFiles ) ) {
968968 # Format the user-visible controls (comment field, submission button)
969969 # in a nice little table
970 - if( $wgUser->isAllowed( 'suppress' ) ) {
 970+ if( $wgUser->isAllowed( 'hiderevision' ) ) {
971971 $unsuppressBox =
972972 "<tr>
973973 <td>&nbsp;</td>

Status & tagging log