r34299 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34298‎ | r34299 | r34300 >
Date:05:46, 6 May 2008
Author:dale
Status:old
Tags:
Comment:
minor IE fixes, added cancel button
Modified paths:
  • /trunk/extensions/MetavidWiki/skins/mv_common.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/images/cancel.png (added) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/jquery/plugins/jquery.autocomplete.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/skins/mv_common.js
@@ -15,11 +15,9 @@
1616 $j(this).css('border','solid red');
1717 do_video_time_update( $j('#mv_end_hr_'+mvd_id).val(), $j('#mv_end_hr_'+mvd_id).val() );
1818 },out:function(){
19 - //@@todo restore "undefined
20 - $j(this).get(0).style.border=null;
 19+ $j(this).css('border','none');
2120 do_video_time_update($j('#mv_start_hr_'+mvd_id).val(), $j('#mv_end_hr_'+mvd_id).val() );
22 - }});
23 -
 21+ }});
2422 //add onchange js hooks:
2523 $j('.mv_adj_hr').change(function(){
2624 //preserve track duration for nav and seq:
Index: trunk/extensions/MetavidWiki/skins/mv_embed/jquery/plugins/jquery.autocomplete.js
@@ -264,10 +264,11 @@
265265 // if the field no longer has focus or if there are no matches, do not display the drop down
266266 if( !hasFocus || data.length == 0 ) return hideResultsNow();
267267
268 - if ($.browser.msie) {
 268+ //messes with layout & ie7 does not have this problem
 269+ /*if ($.browser.msie) {
269270 // we put a styled iframe behind the calendar so HTML SELECT elements don't show through
270271 $results.append(document.createElement('iframe'));
271 - }
 272+ }*/
272273 results.appendChild(dataToDom(data));
273274 // autofill in the complete box w/the first match as long as the user hasn't entered in more data
274275 if( options.autoFill && ($input.val().toLowerCase() == q.toLowerCase()) ) autoFill(data[0][0]);
Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js
@@ -819,21 +819,15 @@
820820 text_clip.start + ' to ' +text_clip.end+
821821 '</div>'+
822822 text_clip.body +
823 - '</div>';
824 -
825 - if($j('#mmbody_'+this.pe.id).length==0)this.show();
826 -
 823+ '</div>';
 824+ if($j('#mmbody_'+this.pe.id).length==0)this.show();
827825 $j('#mmbody_'+this.pe.id +' .mvtt').each(function(){
828 - js_log('searching for insert point..');
829826 if(!inserted){
830827 js_log( ntp2seconds($j(this).attr('start')) + ' > ' + text_clip_start_time);
831828 if( ntp2seconds($j(this).attr('start')) > text_clip_start_time){
832 - inserted=true;
833 -
 829+ inserted=true;
834830 $j(this).before(insertHTML);
835831 }
836 - }else{
837 - js_log('already inserted')
838832 }
839833 });
840834 //js_log('should just append: '+insertHTML);
Index: trunk/extensions/MetavidWiki/skins/mv_embed/images/cancel.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/MetavidWiki/skins/mv_embed/images/cancel.png
___________________________________________________________________
Added: svn:mime-type
841835 + application/octet-stream

Status & tagging log