r34229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34228‎ | r34229 | r34230 >
Date:00:14, 5 May 2008
Author:simetrical
Status:old
Tags:
Comment:
(bug 13949) Special:PrefixIndex/AllPages paging links contain invalid XML
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialAllpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialAllpages.php
@@ -336,16 +336,20 @@
337337
338338 # Do we put a previous link ?
339339 if( isset( $prevTitle ) && $pt = $prevTitle->getText() ) {
340 - $q = 'from=' . $prevTitle->getPartialUrl() . ( $namespace ? '&namespace=' . $namespace : '' );
341 - $prevLink = $sk->makeKnownLinkObj( $self, wfMsgHTML( 'prevpage', $pt ), $q );
 340+ $q = 'from=' . $prevTitle->getPartialUrl()
 341+ . ( $namespace ? '&namespace=' . $namespace : '' );
 342+ $prevLink = $sk->makeKnownLinkObj( $self,
 343+ wfMsgHTML( 'prevpage', htmlspecialchars( $pt ) ), $q );
342344 $out2 .= ' | ' . $prevLink;
343345 }
344346
345347 if( $n == $this->maxPerPage && $s = $dbr->fetchObject($res) ) {
346348 # $s is the first link of the next chunk
347349 $t = Title::MakeTitle($namespace, $s->page_title);
348 - $q = 'from=' . $t->getPartialUrl() . ( $namespace ? '&namespace=' . $namespace : '' );
349 - $nextLink = $sk->makeKnownLinkObj( $self, wfMsgHtml( 'nextpage', $t->getText() ), $q );
 350+ $q = 'from=' . $t->getPartialUrl()
 351+ . ( $namespace ? '&namespace=' . $namespace : '' );
 352+ $nextLink = $sk->makeKnownLinkObj( $self,
 353+ wfMsgHtml( 'nextpage', htmlspecialchars( $t->getText() ) ), $q );
350354 $out2 .= ' | ' . $nextLink;
351355 }
352356 $out2 .= "</td></tr></table><hr />";
Index: trunk/phase3/RELEASE-NOTES
@@ -247,8 +247,8 @@
248248 * (bug 13925) Fix bad HTML on search results list
249249 * (bug 13934) Fixing the link to GNU General Public License Version 2
250250 * Show correct accesskey prefix for Firefox 3 beta (Alt-Shift-, not Alt-)
 251+* (bug 13949) Special:PrefixIndex/AllPages paging links contain invalid XML
251252
252 -
253253 === API changes in 1.13 ===
254254
255255 * Fixing main page display in meta=siteinfo

Follow-up revisions

RevisionCommit summaryAuthorDate
r37704Per comment in bug 13949: fix XHTML error in Special:Prefixindex (was already...ialex17:42, 15 July 2008

Status & tagging log