r34064 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34063‎ | r34064 | r34065 >
Date:22:05, 30 April 2008
Author:brion
Status:old
Tags:
Comment:
Revert r34029 - "(bug 11659) Urldecode image names in galleries"

The indiscriminate use of urldecode() here breaks image names containing a + character.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -4337,7 +4337,7 @@
43384338 if ( count( $matches ) == 0 ) {
43394339 continue;
43404340 }
4341 - $tp = Title::newFromText( urldecode( $matches[1] ) );
 4341+ $tp = Title::newFromText( $matches[1] );
43424342 $nt =& $tp;
43434343 if( is_null( $nt ) ) {
43444344 # Bogus title. Ignore these so we don't bomb out later.
Index: trunk/phase3/RELEASE-NOTES
@@ -224,7 +224,6 @@
225225 * (bug 13866) skins/common/shared.css - invalid attribute fixing
226226 * Hide edit section links on Special:Undelete
227227 * (bug 13860) Fix "Justify paragraphs" option for Modern skin
228 -* (bug 11659) Urldecode image names in galleries
229228 * (bug 13168) accessibility links in Modern skin link to wrong anchor id
230229 * (bug 13185) No line break after 'subpages' class in Modern skin
231230 * (bug 13583) No "poweredby" in Modern skin

Follow-up revisions

RevisionCommit summaryAuthorDate
r35683(bug 11659) Urldecode image names in galleries (fixed in a similar way as don...btongminh18:31, 1 June 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34029(bug 11659) Urldecode image names in galleriesbtongminh21:50, 29 April 2008

Status & tagging log