r34062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r34061‎ | r34062 | r34063 >
Date:21:05, 30 April 2008
Author:ialex
Status:old
Tags:
Comment:
(bug 13891) Show categories box even if all categories are hidden and user has "show hidden categories" option on
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -725,11 +725,12 @@
726726
727727 $classes = 'catlinks';
728728
729 - if(FALSE === strpos($catlinks,'<div id="mw-normal-catlinks">')) {
 729+ if( strpos( $catlinks, '<div id="mw-normal-catlinks">' ) === false &&
 730+ strpos( $catlinks, '<div id="mw-hidden-catlinks" class="mw-hidden-cats-hidden">' ) !== false ) {
730731 $classes .= ' catlinks-allhidden';
731732 }
732733
733 - if(!empty($catlinks)) {
 734+ if( !empty( $catlinks ) ){
734735 return "<div id='catlinks' class='$classes'>{$catlinks}</div>";
735736 }
736737 }
Index: trunk/phase3/RELEASE-NOTES
@@ -230,6 +230,8 @@
231231 * (bug 13583) No "poweredby" in Modern skin
232232 * (bug 13880) "Printable" link in Modern skin now formats as print mode
233233 * (bug 13885) Bump default $wgSVGMaxSize from 1024 to 2048 pixels
 234+* (bug 13891) Show categories box even if all categories are hidden and user has
 235+ "show hidden categories" option on
234236
235237
236238 === API changes in 1.13 ===

Status & tagging log