r34058 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r34057‎ | r34058 | r34059 >
Date:18:29, 30 April 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 13880) "Printable" link in Modern skin now formats as print mode

Problem was that the Modern skin uses a different way of setting up the print stylesheet from the other skins.

Others:
* always include main stylesheet
* override that stuff with print stylesheet for print media or ?printable=yes

Modern:
* include main stylesheet only for screen & projection media only
* add some additional print styles for print media or ?printable=yes

The screen stylesheet was still being used when ?printable=yes is set, but would be hidden when actually printing. I've changed it to now exclude the screen stylesheets when ?printable=yes is switched in, so it looks the same on screen as when actually printing.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Modern.php
——@@ -61,10 +61,12 @@
6262 <meta http-equiv="Content-Type" content="<?php $this->text('mimetype') ?>; charset=<?php $this->text('charset') ?>" />
6363 <?php $this->html('headlinks') ?>
6464 <title><?php $this->text('pagetitle') ?></title>
 65+ <?php if(empty($this->data['printable']) ) { ?>
6566 <style type="text/css" media="screen, projection">/*<![CDATA[*/
6667 @import "<?php $this->text('stylepath') ?>/common/shared.css?<?php echo $GLOBALS['wgStyleVersion'] ?>";
6768 @import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/main.css?<?php echo $GLOBALS['wgStyleVersion'] ?>";
6869 /*]]>*/</style>
 70+ <?php } ?>
6971 <link rel="stylesheet" type="text/css" <?php if(empty($this->data['printable']) ) { ?>media="print"<?php } ?> href="<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/print.css?<?php echo $GLOBALS['wgStyleVersion'] ?>" />
7072 <!--[if lt IE 7]><meta http-equiv="imagetoolbar" content="no" /><![endif]-->
7173
Index: trunk/phase3/RELEASE-NOTES
——@@ -228,7 +228,9 @@
229229 * (bug 13168) accessibility links in Modern skin link to wrong anchor id
230230 * (bug 13185) No line break after 'subpages' class in Modern skin
231231 * (bug 13583) No "poweredby" in Modern skin
 232+* (bug 13880) "Printable" link in Modern skin now formats as print mode
232233
 234+
233235 === API changes in 1.13 ===
234236
235237 * Fixing main page display in meta=siteinfo

Status & tagging log