r34028 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r34027‎ | r34028 | r34029 >
Date:20:48, 29 April 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 13860) Fix "Justify paragraphs" option for Modern skin

Adds the appropriate id for Modern skin to the set of justify CSS thingies.
This isn't totally satisfactory; the various skins should be refactored to unify this stuff better, but it'll do for now.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -516,7 +516,7 @@
517517 END;
518518 }
519519 if( $wgUser->getOption( 'justify' ) ) {
520 - $s .= "#article, #bodyContent { text-align: justify; }\n";
 520+ $s .= "#article, #bodyContent, #mw_content { text-align: justify; }\n";
521521 }
522522 if( !$wgUser->getOption( 'showtoc' ) ) {
523523 $s .= "#toc { display: none; }\n";
Index: trunk/phase3/RELEASE-NOTES
——@@ -222,7 +222,9 @@
223223 * Added 'application/x-dia-diagram' MediaWiki's known MIME types
224224 * (bug 13866) skins/common/shared.css - invalid attribute fixing
225225 * Hide edit section links on Special:Undelete
 226+* (bug 13860) Fix "Justify paragraphs" option for Modern skin
226227
 228+
227229 === API changes in 1.13 ===
228230
229231 * Fixing main page display in meta=siteinfo

Status & tagging log