r33910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33909‎ | r33910 | r33911 >
Date:14:40, 26 April 2008
Author:catrope
Status:old
Tags:
Comment:
API: Make ApiResult::setIndexedTagName_recursive() actually work. This fixes bug 13836
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiResult.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiResult.php
@@ -147,7 +147,7 @@
148148 {
149149 if(!is_array($arr))
150150 return;
151 - foreach($arr as $a)
 151+ foreach($arr as &$a)
152152 {
153153 if(!is_array($a))
154154 continue;
Index: trunk/phase3/RELEASE-NOTES
@@ -267,6 +267,8 @@
268268 * (bug 13792) Broken titles are now silently skipped in search results.
269269 * (bug 13819) exturlusage paging skipped an item
270270 * Fixed handling of usernames containing spaces in list=block
 271+* (bug 13836) Fixed fatal errors resulting from combining iiprop=metadata with
 272+ format=xml
271273
272274 === Languages updated in 1.13 ===
273275

Follow-up revisions

RevisionCommit summaryAuthorDate
r34658Backport API bugfixes from trunk to REL1_12 that caused PHP to spit out fatal...btongminh13:33, 12 May 2008

Status & tagging log