r33562 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33561‎ | r33562 | r33563 >
Date:20:01, 18 April 2008
Author:ialex
Status:old
Tags:
Comment:
Don't need to escape it, it's already done by Xml::element(), thanks to nikerabbit to have noticed it
Modified paths:
  • /trunk/extensions/Configure/Configure.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.body.php
@@ -372,8 +372,8 @@
373373 Xml::element( 'input', array( 'type' => 'submit', 'name' => 'wpSave', 'class' => 'btnSavePrefs', 'value' => wfMsgHtml( 'configure-btn-save' ) ) ) . "\n" .
374374 Xml::closeElement( 'div' ) . "\n" .
375375 Xml::closeElement( 'div' ) . "\n" .
376 - Xml::element( 'input', array( 'type' => 'hidden', 'name' => 'wpEditToken', 'value' => htmlspecialchars( $wgUser->editToken() ) ) ) . "\n" .
377 - ( $wiki ? Xml::element( 'input', array( 'type' => 'hidden', 'name' => 'wpWiki', 'value' => htmlspecialchars( $wiki ) ) ) . "\n" : '' ) .
 376+ Xml::element( 'input', array( 'type' => 'hidden', 'name' => 'wpEditToken', 'value' => $wgUser->editToken() ) ) . "\n" .
 377+ ( $wiki ? Xml::element( 'input', array( 'type' => 'hidden', 'name' => 'wpWiki', 'value' => $wiki ) ) . "\n" : '' ) .
378378 Xml::closeElement( 'div' ) . "\n" .
379379 Xml::closeElement( 'form' )
380380 );
@@ -515,7 +515,7 @@
516516 if( $allowed )
517517 $text .= Xml::element( 'input', array(
518518 'name' => 'wp' . $conf . "-key-{$i}",
519 - 'type' => 'text', 'value' => htmlspecialchars( $key )
 519+ 'type' => 'text', 'value' => $key
520520 ) ) . "<br/>\n";
521521 else
522522 $text .= htmlspecialchars( $key );
@@ -523,7 +523,7 @@
524524 if( $allowed )
525525 $text .= Xml::element( 'input', array(
526526 'name' => 'wp' . $conf . "-val-{$i}",
527 - 'type' => 'text', 'value' => htmlspecialchars( $val )
 527+ 'type' => 'text', 'value' => $val
528528 ) ) . "<br/>\n";
529529 else
530530 $text .= htmlspecialchars( $val );
@@ -573,7 +573,7 @@
574574 $text .= '<tr><td>'.htmlspecialchars( $name ) . '</td><td>';
575575 $text .= Xml::element( 'input', array(
576576 'name' => 'wp' . $conf . "-ns{$ns}",
577 - 'type' => 'text', 'value' => htmlspecialchars( isset( $default[$ns] ) ? $default[$ns] : '' )
 577+ 'type' => 'text', 'value' => isset( $default[$ns] ) ? $default[$ns] : ''
578578 ) ) . "<br/>\n";
579579 $text .= '</td></tr>';
580580 }

Status & tagging log