r33541 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33540‎ | r33541 | r33542 >
Date:06:57, 18 April 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Expiry handling is really sub-optimal here
Modified paths:
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -54,7 +54,8 @@
5555 } else if ( strlen($this->mTitle->mRestrictionsExpiry) == 0 ) {
5656 $this->mExpiry = '';
5757 } else {
58 - $this->mExpiry = wfTimestamp( TS_RFC2822, $this->mTitle->mRestrictionsExpiry );
 58+ // FIXME: this format is not user friendly
 59+ $this->mExpiry = wfTimestamp( TS_ISO_8601, $this->mTitle->mRestrictionsExpiry );
5960 }
6061 }
6162
@@ -170,6 +171,8 @@
171172 return false;
172173 }
173174
 175+ // Fixme: non-qualified absolute times are not in users specified timezone
 176+ // and there isn't notice about it in the ui
174177 $expiry = wfTimestamp( TS_MW, $expiry );
175178
176179 if ( $expiry < wfTimestampNow() ) {

Status & tagging log