r33502 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33501‎ | r33502 | r33503 >
Date:18:15, 17 April 2008
Author:raymond
Status:old
Tags:
Comment:
Fix error from r33495: class -> id. Thanks to Nikerabbit.
Modified paths:
  • /trunk/phase3/includes/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
@@ -888,10 +888,9 @@
889889 } else {
890890 $formatted = $wgLang->timeanddate( $epoch, false, $key );
891891 }
892 - $checked = ( $key == $this->mDate ) ? true : false;
893892 $wgOut->addHTML(
894893 Xml::tags( 'div', null,
895 - Xml::radioLabel( $formatted, 'wpDate', $key, "wpDate$idCnt", $checked )
 894+ Xml::radioLabel( $formatted, 'wpDate', $key, "wpDate$idCnt", $key == $this->mDate )
896895 ) . "\n"
897896 );
898897 $idCnt++;
@@ -910,7 +909,7 @@
911910 $this->addRow( wfMsg( 'localtime' ), $nowlocal ) .
912911 $this->addRow(
913912 Xml::label( wfMsg( 'timezoneoffset' ), 'wpHourDiff' ),
914 - Xml::input( 'wpHourDiff', 6, $this->mHourDiff, array( 'class' => 'wpHourDiff' ) ) ) .
 913+ Xml::input( 'wpHourDiff', 6, $this->mHourDiff, array( 'id' => 'wpHourDiff' ) ) ) .
915914 "<tr>
916915 <td></td>
917916 <td class='mw-submit'>" .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r33495* Tweaks for sections date/time and search of SpecialPreferences:...raymond17:26, 17 April 2008

Status & tagging log