r33492 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33491‎ | r33492 | r33493 >
Date:17:07, 17 April 2008
Author:aaron
Status:old
Tags:
Comment:
Form tweaks
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -806,7 +806,6 @@
807807 }
808808 }
809809 $quantity = count( $label );
810 - $form .= "\n" . Xml::openElement( 'span' );
811810 $form .= "<b>" . wfMsgHtml("revreview-$quality") . ":</b>&nbsp;";
812811 # If the sum of qualities of all flags is above 6, use drop down boxes
813812 # 6 is an arbitrary value choosen according to screen space and usability
@@ -838,19 +837,17 @@
839838 "wp$quality".$selected, true, $attribs ) . "\n";
840839 } else {
841840 $attribs = array( 'class' => "fr-rating-option-1", 'onchange' => "updateRatingForm()" );
842 - # TODO: FlaggedRevsPage.php needs to be patched as well in order to uncheck a checkbox
843841 $form .= Xml::checkLabel( wfMsg( "revreview-$label[1]" ), "wp$quality", "wp$quality"."1",
844842 ($selected == 1), $attribs ) . "\n";
845843 }
846844 $form .= ($remaining > 0) ? "&nbsp;&nbsp;" : "";
847845 }
848 - $form .= Xml::closeElement( 'span' );
849846 }
850847 $form .= Xml::closeElement( 'span' );
851848
852849 if( $wgFlaggedRevComments && $wgUser->isAllowed( 'validate' ) ) {
853850 $form .= "<div id='mw-notebox'>\n";
854 - $form .= "<p>" . wfMsgHtml( 'revreview-notes' ) . "</p>\n";
 851+ $form .= "<p></strong>" . wfMsgHtml( 'revreview-notes' ) . "</p>\n";
855852 $form .= "<p><textarea name='wpNotes' id='wpNotes' class='fr-reason-box'
856853 rows='2' cols='80' style='width:95%; margin: 0em 1em 0em .5em;'/></p>\n";
857854 $form .= "</div>\n";
@@ -889,14 +886,14 @@
890887 $checkCode = FlaggedRevs::getValidationKey( $templateParams, $imageParams, $wgUser->getID() );
891888 $form .= Xml::hidden( 'validatedParams', $checkCode ) . "\n";
892889
893 - $form .= "<span style='white-space: nowrap'>"; // get comment and submit on same line
 890+ $form .= "<div style='white-space: nowrap'>"; // get comment and submit on same line
894891 # Hide comment if needed
895892 $form .= "<span id='mw-commentbox'>" .
896893 Xml::inputLabel( wfMsg('revreview-log'), 'wpReason', 'wpReason', 50, '', array('class' => 'fr-comment-box') ) .
897894 "</span>";
898895
899896 $form .= "&nbsp;&nbsp;&nbsp;".Xml::submitButton( wfMsgHtml('revreview-submit'), array('id' => 'mw-submitbutton') );
900 - $form .= "</span>";
 897+ $form .= "</div>";
901898
902899 $form .= Xml::closeElement( 'fieldset' );
903900 $form .= Xml::closeElement( 'form' );

Status & tagging log