r33390 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33389‎ | r33390 | r33391 >
Date:20:44, 15 April 2008
Author:catrope
Status:old
Tags:
Comment:
Adding CSS class for nested <fieldset>s. Nesting fieldsets used to cause a huge amount of whitespace between the parent and the child fieldset, this commit adds a class that circumvents this.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -177,6 +177,10 @@
178178 padding: 0 1em 1em;
179179 line-height: 1.5em;
180180 }
 181+fieldset.nested {
 182+ margin: 0 0 0.5em 0;
 183+ padding: 0 0.5em 0.5em;
 184+}
181185 legend {
182186 padding: .5em;
183187 font-size: 95%;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1336,7 +1336,7 @@
13371337 * to ensure that client-side caches don't keep obsolete copies of global
13381338 * styles.
13391339 */
1340 -$wgStyleVersion = '134';
 1340+$wgStyleVersion = '135';
13411341
13421342
13431343 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
@@ -75,6 +75,8 @@
7676 * (bug 10457) Reorganize Special:Specialpages
7777 * Add a new hook EditPageBeforeConflictDiff to allow extensions like FCKeditor
7878 to modify the output for edit conflicts.
 79+* Add class="nested" for <fieldset>s so fieldsets inside fieldsets get
 80+ a slightly less huge margin and padding.
7981
8082 === Bug fixes in 1.13 ===
8183

Status & tagging log