r32999 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32998‎ | r32999 | r33000 >
Date:00:02, 9 April 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 11039) Add missing labels on protection form
May help with screen readers which get a bit lost on the listbox-in-table layout
Fixed up some release notes entries
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -233,7 +233,10 @@
234234
235235 foreach( $this->mRestrictions as $action => $required ) {
236236 /* Not all languages have V_x <-> N_x relation */
237 - $out .= Xml::element( 'th', null, wfMsg( 'restriction-' . $action ) );
 237+ $label = Xml::element( 'label',
 238+ array( 'for' => "mwProtect-level-$action" ),
 239+ wfMsg( 'restriction-' . $action ) );
 240+ $out .= "<th>$label</th>";
238241 }
239242 $out .= "</tr>
240243 <tr>\n";
Index: trunk/phase3/RELEASE-NOTES
@@ -63,8 +63,7 @@
6464 * (bug 13490) Show upload/file size limit on upload form
6565 * Redesign of Special:Userrights
6666 * Make rev_deleted log entries more intelligible.
67 -* (6943) Added PAGESINCATEGORY: magic word
68 -* (13624) Fix regression with manual thumb= parameter on images
 67+* (bug 6943) Added PAGESINCATEGORY: magic word
6968
7069
7170 === Bug fixes in 1.13 ===
@@ -159,7 +158,10 @@
160159 * (bug 13630) Fixed warnings for pass by reference at call time in
161160 Special:Revisiondelete when generating the log entry.
162161 * (bug 12064) BeforePageDisplay hook is now called for all skins
 162+* (bug 13624) Fix regression with manual thumb= parameter on images
 163+* (bug 11039) Add missing labels on protection form
163164
 165+
164166 === API changes in 1.13 ===
165167
166168 * Fixing main page display in meta=siteinfo

Status & tagging log