r32972 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32971‎ | r32972 | r32973 >
Date:18:20, 8 April 2008
Author:brion
Status:old
Tags:
Comment:
Revert r32842, r32942 for now.
* The date-split view is visually disjoint; loss of distinguishing bullets makes the lines harder to read and distinguish, while the extra date headers cause significant vertical expansion of log lists when searched on specific criteria.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -136,19 +136,13 @@
137137 private function getTitlePattern( $pattern ) {
138138 return Xml::checkLabel( wfMsg( 'log-title-wildcard' ), 'pattern', 'pattern', $pattern );
139139 }
140 -
141 -
142 - protected function getWrapperElement() {
143 - global $wgDateGroupedLogs;
144 - return $wgDateGroupedLogs ? 'div' : 'ul';
145 - }
146140
147141 public function beginLogEventsList() {
148 - return Xml::openElement( $this->getWrapperElement() ) . "\n";
 142+ return "<ul>\n";
149143 }
150144
151145 public function endLogEventsList() {
152 - return Xml::closeElement( $this->getWrapperElement() ) . "\n";
 146+ return "</ul>\n";
153147 }
154148
155149 /**
@@ -260,24 +254,8 @@
261255 } else {
262256 $action = LogPage::actionText( $row->log_type, $row->log_action, $title, $this->skin, $paramArray, true );
263257 }
264 -
265 - global $wgDateGroupedLogs;
266 - if ( $wgDateGroupedLogs ) {
267 - $time = $wgLang->time( wfTimestamp(TS_MW, $row->log_timestamp), true );
268 - $date = $wgLang->date( wfTimestamp(TS_MW, $row->log_timestamp), true );
269 - $line = Xml::tags('div', array( 'class' => 'mw-log-entry' ), "$del$time $userLink $action $comment $revert" );
270 -
271 - static $lastdate = false;
272 - if ( $date !== $lastdate ) {
273 - $lastdate = $date;
274 - return Xml::element('h4', null, $date) . "\n" . $line;
275 - } else {
276 - return $line;
277 - }
278 - } else {
279 - return Xml::tags('li', null, "$del$time $userLink $action $comment $revert" );
280 - }
281 -
 258+
 259+ return "<li>$del$time $userLink $action $comment $revert</li>\n";
282260 }
283261
284262 /**
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2499,11 +2499,6 @@
25002500 );
25012501
25022502 /**
2503 - * Group logs under date headings similar to enhanced recent changes.
2504 - */
2505 -$wgDateGroupedLogs = true;
2506 -
2507 -/**
25082503 * Experimental preview feature to fetch rendered text
25092504 * over an XMLHttpRequest from JavaScript instead of
25102505 * forcing a submit and reload of the whole page.
Index: trunk/phase3/RELEASE-NOTES
@@ -28,7 +28,6 @@
2929 * Removed $wgAlternateMaster, use $wgLBFactoryConf
3030 * (bug 13562) Misspelled option $wgUserNotifedOnAllChanges changed to
3131 $wgUserNotifiedOnAllChanges
32 -* $wgDateGroupedLogs can be set to false to restore old log formatting
3332
3433 === New features in 1.13 ===
3534
@@ -64,7 +63,6 @@
6564 * (bug 13490) Show upload/file size limit on upload form
6665 * Redesign of Special:Userrights
6766 * Make rev_deleted log entries more intelligible.
68 -* Logs are grouped under date headings similar to enhanced changes list
6967 * (6943) Added PAGESINCATEGORY: magic word
7068 * (13624) Fix regression with manual thumb= parameter on images
7169

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32842* Logs are grouped under date headings similar to enhanced changes list...nikerabbit08:59, 6 April 2008
r32942* Add a class for stylingnikerabbit07:26, 8 April 2008

Status & tagging log